Add fallback for ForegroundServiceStartNotAllowedException in Android 31+ #6808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aitorvs
force-pushed
the
fix/aitor/vpn/crash_ForegroundServiceStartNotAllowedException
branch
from
d955802 to
c7e5b7d
Compare
karlenDimla
approved these changes
Sep 17, 2025
karlenDimla
deleted the
fix/aitor/vpn/crash_ForegroundServiceStartNotAllowedException
branch
aitorvs
added a commit
that referenced
this pull request
Sep 23, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1211418384396819?focus=true ### Description In #6808 we bubbled up the `ForegroundServiceStartNotAllowedException` to notifyVpnStart function, when calling `startForeground` method. This didn't get rid of the crashes but was a bit of an improvement. This PR will try-catch the startForeground call and return the appropriate error so that the error path can be executed. The error path sends a pixel (m_vpn_ev_notify_start_failed_c/d) are expected to increase and will also stop the service showing the disabled notification. Which is a better UX ### Steps to test this PR Smoke test the VPN and AppTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1206535923706701?focus=true
Description
Work around platform bug (b/229000935) where startForegroundService() for
VpnService can throw ForegroundServiceStartNotAllowedException when called
from background. We now catch this and fall back to startService(), which
is allowed for VPNs. Service still promotes itself to foreground as usual.
Steps to test this PR
Smoke test AppTP and VPN on off scenarios for Android on 31+ and below 31