Render password management views as list items inside RecyclerView #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell
force-pushed
the
feature/craig/make_all_password_management_screen_scrollable
branch
3 times, most recently
from
713c5bb to
c821f6e
Compare
CDRussell
commented
Feb 14, 2025
| import kotlinx.coroutines.launch | ||
| import kotlinx.coroutines.withContext | ||
|
|
||
| class AutofillManagementRecyclerAdapterLegacy( |
There was a problem hiding this comment.
This class is as touched as possible and is largely just the existing production version of AutofillManagementRecyclerAdapter
CDRussell
force-pushed
the
feature/craig/make_all_password_management_screen_scrollable
branch
from
c821f6e to
9b0b529
Compare
CDRussell
commented
Feb 14, 2025
| android:layout_height="match_parent" | ||
| android:background="#30F0" |
There was a problem hiding this comment.
Temporary while in development
CDRussell
force-pushed
the
feature/craig/make_all_password_management_screen_scrollable
branch
3 times, most recently
from
6009719 to
8b02879
Compare
CDRussell
force-pushed
the
feature/craig/make_all_password_management_screen_scrollable
branch
from
8b02879 to
d617663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/608920331025315/1209109157109863
Description
Steps to test this PR
Feature 1
UI changes