Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to generate Tabs from Developer Settings #5653

Merged
merged 9 commits into from
Feb 14, 2025

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Feb 14, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1209407906356235

Description

Added a new developer settings screen for managing tabs, allowing developers to quickly create or clear multiple tabs for testing purposes. The screen includes functionality to specify the number of tabs to create and automatically generates tabs with random privacy-focused URLs.

Steps to test this PR

Tab Management

  • Access the new Tabs section from Developer Settings
  • Enter a number of tabs to create and tap "Add Tabs"
  • Verify tabs are created with random URLs from the predefined list
  • Verify the tab count header updates correctly
  • Test the "Clear Tabs" button removes all tabs
  • Verify navigation and toolbar functionality works as expected

UI changes

Screen_recording_20250214_140120.mp4

we allow adding and clearing, defaulting to 100 for a good test number
i just created a random list of urls, feel free to suggest any or suggest removal of any
@mikescamell mikescamell changed the title Add test Tab generation to Developer Settings Add ability to generate Tabs from to Developer Settings Feb 14, 2025
@mikescamell mikescamell marked this pull request as ready for review February 14, 2025 14:03
@0nko 0nko self-assigned this Feb 14, 2025
Copy link
Member

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, nice job! 🏅

@mikescamell mikescamell changed the title Add ability to generate Tabs from to Developer Settings Add ability to generate Tabs from Developer Settings Feb 14, 2025
I don't know why moving the flow layout after works but it's not complaining anymore
@mikescamell mikescamell enabled auto-merge (squash) February 14, 2025 16:24
@mikescamell mikescamell merged commit 5f5a0a7 into develop Feb 14, 2025
5 checks passed
@mikescamell mikescamell deleted the feature/mike/add-tab-generation-to-dev-settings branch February 14, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants