SplashScreen Animation: Add wink animation #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7 tasks
malmstein
approved these changes
Feb 7, 2025
we can only play the new wink animation on sdk 32+, otherwise we stick to our existing static splash logo It's necessary to add windowSplashScreenAnimationDuration and this is only used by sdk32, sdk33+ determine the duration via the AnimatedVectorDrawable itself
I observed that on warm starts the animation never gets to fully play out, it seems like it's dismissed before being able to finish which makes it look like something is broken. Therefore we can register an exit animation listener and use the length of the animation to determine when we should actually move on which results in the animation being played to completion on warm starts.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209192748061745 Added a new pixel tracking event `m_splashscreen_shown` that fires when the app's splash screen is displayed. The pixel is configured to remove all parameters for privacy protection. _Splash Screen Pixel Cold Start_ - [ ] Launch the app from a cold start (force close the app if necessary) - [ ] Verify in the network logs that the `m_splashscreen_shown` pixel is fired - [ ] Confirm that the pixel is sent without ATB or other tracking parameters _Splash Screen Pixel Warm Start_ - [ ] Press back to close the app - [ ] Open the app - [ ] Verify in the network logs that the `m_splashscreen_shown` pixel is fired - [ ] Confirm that the pixel is sent without ATB or other tracking parameters No UI changes were made in this PR.
mikescamell
force-pushed
the
feature/mike/splashscreen-animation/add-wink-animation
branch
from
641425c to
4274b24
Compare
now with more refined winking
mikescamell
deleted the
feature/mike/splashscreen-animation/add-wink-animation
branch
mikescamell
added a commit
that referenced
this pull request
Feb 19, 2025
This reverts commit 1af0d49
mikescamell
added a commit
that referenced
this pull request
Feb 19, 2025
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209441074191255 ### Description This reverts commit 1af0d49. There have been some Splashscreen issues on Android 12L so we're reverting and going to try and fix for the next release ### Steps to test this PR _Splashscreen_ - [ ] Open app on a number of different SDK versions, a good sample is 26, 32, 35 - [ ] Check the static logo shows and the app launches (remember there is a bug if you launch the app from Android Studio on to an Android 12L device where you only see the logo if you launch from the home screen) ### UI changes Back to previous static logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209192748061740/f
Description
Adds a new wink animation to the splashscreen for devices on sdk 32+😉
On devices <32 we show the existing static logo splashscreen.
Steps to test this PR
Splashscreen on SDK 32+
Splashscreen on SDK < 31
Demo
Light
light_demo.mp4
Dark
dark_demo.mp4