Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trying to get non-existent subscription #5418

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Dec 19, 2024

Task/Issue URL: https://app.asana.com/0/1205648422731273/1209011223549610/f

Description

In certain scenarios, the app makes unnecessary requests to api/subscriptions endpoint - this PR addresses that. More context in the linked task.

Steps to test this PR

See task.

No UI changes

Copy link
Contributor Author

lmac012 commented Dec 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lmac012 lmac012 marked this pull request as ready for review December 19, 2024 20:40
@lmac012 lmac012 requested a review from karlenDimla December 19, 2024 20:41
Copy link
Contributor

@karlenDimla karlenDimla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are a bit hard to test. Looking at the code changes, It makes sense.

@lmac012 lmac012 merged commit d045610 into develop Dec 20, 2024
8 checks passed
@lmac012 lmac012 deleted the fix/lukasz/subscription-data-refresh branch December 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants