-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy Pro Subscriptions: Update some internal models and methods #5402
Merged
nalcalag
merged 14 commits into
develop
from
feature/noelia/refactor_get_subscription_offer
Dec 21, 2024
Merged
Privacy Pro Subscriptions: Update some internal models and methods #5402
nalcalag
merged 14 commits into
develop
from
feature/noelia/refactor_get_subscription_offer
Dec 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nalcalag
changed the title
Refactor getSubscriptionOffer method
Privacy Pro Subscriptions: Update some internal models and methods
Dec 18, 2024
nalcalag
force-pushed
the
feature/noelia/refactor_get_subscription_offer
branch
from
December 19, 2024 16:53
ba994ca
to
1e619b1
Compare
nalcalag
force-pushed
the
feature/noelia/refactor_get_subscription_offer
branch
from
December 19, 2024 17:10
1e619b1
to
e766559
Compare
nalcalag
changed the title
Privacy Pro Subscriptions: Update some internal models and methods
Privacy Pro Subscriptions: Update SubscriptionOffer models and methods
Dec 20, 2024
nalcalag
changed the title
Privacy Pro Subscriptions: Update SubscriptionOffer models and methods
Privacy Pro Subscriptions: Update some internal models and methods
Dec 20, 2024
lmac012
reviewed
Dec 20, 2024
...ions-impl/src/main/java/com/duckduckgo/subscriptions/impl/ui/SubscriptionWebViewViewModel.kt
Outdated
Show resolved
Hide resolved
nalcalag
force-pushed
the
feature/noelia/refactor_get_subscription_offer
branch
from
December 20, 2024 14:16
8bc1834
to
0f00ed6
Compare
lmac012
reviewed
Dec 20, 2024
...iptions-impl/src/test/java/com/duckduckgo/subscriptions/impl/RealSubscriptionsManagerTest.kt
Outdated
Show resolved
Hide resolved
lmac012
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201807753394693/1209007672205184/f
Description
Update some subscriptions models in order to support free trials on mobile:
SubscriptionOffer
modelOptionsJson
modelgetSubscriptionOffer()
methodSteps to test this PR
Pre steps
Privacy Pro Eligible US
Privacy Pro Eligible ROW (Optional)
Privacy Pro No Eligible
No UI changes