Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Pro Subscriptions: Update some internal models and methods #5402

Merged
merged 14 commits into from
Dec 21, 2024

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Dec 17, 2024

Task/Issue URL: https://app.asana.com/0/1201807753394693/1209007672205184/f

Description

Update some subscriptions models in order to support free trials on mobile:

  • SubscriptionOffer model
  • OptionsJson model
  • getSubscriptionOffer() method

Steps to test this PR

Pre steps

  • Apply patch to being able to test subscriptions in staging

Privacy Pro Eligible US

  • Make sure you are US eligible
  • Install form branch
  • Check browser works as expected
  • Go to Settings
  • Check you can see Privacy Pro option
  • Tap on that option
  • Check Subscription page looks as expected
  • Purchase any of the options and check it works well
  • Go to Subscription Settings
  • Check everything works as expected

Privacy Pro Eligible ROW (Optional)

  • Make sure you are ROW eligible
  • Install form branch
  • Check browser works as expected
  • Go to Settings
  • Check you can see Privacy Pro option
  • Tap on that option
  • Check Subscription page looks as expected
  • Purchase any of the options and check it works well
  • Go to Subscription Settings
  • Check everything works as expected

Privacy Pro No Eligible

  • Install form branch
  • Check browser works as expected
  • Go to Settings
  • Check you can't see Privacy Pro option

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag changed the title Refactor getSubscriptionOffer method Privacy Pro Subscriptions: Update some internal models and methods Dec 18, 2024
@nalcalag nalcalag force-pushed the feature/noelia/refactor_get_subscription_offer branch from ba994ca to 1e619b1 Compare December 19, 2024 16:53
@nalcalag nalcalag marked this pull request as ready for review December 19, 2024 16:54
@nalcalag nalcalag force-pushed the feature/noelia/refactor_get_subscription_offer branch from 1e619b1 to e766559 Compare December 19, 2024 17:10
@nalcalag nalcalag changed the title Privacy Pro Subscriptions: Update some internal models and methods Privacy Pro Subscriptions: Update SubscriptionOffer models and methods Dec 20, 2024
@nalcalag nalcalag changed the title Privacy Pro Subscriptions: Update SubscriptionOffer models and methods Privacy Pro Subscriptions: Update some internal models and methods Dec 20, 2024
@nalcalag nalcalag force-pushed the feature/noelia/refactor_get_subscription_offer branch from 8bc1834 to 0f00ed6 Compare December 20, 2024 14:16
Copy link
Contributor

@lmac012 lmac012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nalcalag nalcalag merged commit 38fc930 into develop Dec 21, 2024
6 checks passed
@nalcalag nalcalag deleted the feature/noelia/refactor_get_subscription_offer branch December 21, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants