Omnibar: Pixel and Clear action regressions

[malmstein]

Task/Issue URL: https://app.asana.com/0/1205782002757341/1208820359395089/f

Description

Steps to test this PR

Looks at this task for different scenarios: https://app.asana.com/0/1174433894299346/1208812333027437/f

Pixel for clearing address bar - Site

• Navigate to a site
• Tap into address bar
• X to delete entry (don’t type anything new)
• Swipe gesture to close keyboard
• Verify pixel m_addressbar_focus_clear_entry_website is fired only once

Pixel for clearing address bar - SERP

• Navigate to a site
• Tap into address bar
• X to delete entry (don’t type anything new)
• Swipe gesture to close keyboard
• Verify pixel m_addressbar_focus_clear_entry_serp is fired only once

Pixel for clearing address bar - NTP

• Navigate to a site
• Tap into address bar
• X to delete entry (don’t type anything new)
• Swipe gesture to close keyboard
• Verify pixel m_addressbar_focus_clear_entry_ntp is fired only once

Swipe gesture to close keyboard - Site

• Navigate to a site
• Tap into address bar
• X to delete entry (don’t type anything new)
• Swipe gesture to close keyboard
• Verify Site url is displayed

Swipe gesture to close keyboard - SERP

• Enter a search query on SERP
• Tap into address bar
• X to delete entry (don’t type anything new)
• Swipe gesture to close keyboard
• Verify query is displayed

Manually close keyboard + Scroll- Site

• Navigate to a site
• Tap into address bar
• X to delete entry (don’t type anything new)
• Manually close keyboard
• Scroll down the site
• Verify Site url is displayed

Manually close keyboard + Scroll- SERP

• Enter a search query on SERP
• Tap into address bar
• X to delete entry (don’t type anything new)
• Manually close keyboard
• Scroll down the site
• Verify query is displayed

Close keyboard - Site

• Ensure 3 button navigation is enabled (via device Settings)
• Navigate to a site
• Tap into address bar
• X to delete entry (don’t type anything new)
• Close keyboard (press back)
• Verify Site url is displayed

Close keyboard - SERP

• Ensure 3 button navigation is enabled (via device Settings)
• Enter a search query on SERP
• Tap into address bar
• X to delete entry (don’t type anything new)
• Close keyboard (press back)
• Verify query is displayed

[malmstein]

• Omnibar: Pixel and Clear action regressions #5304 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[0nko]

@malmstein While testing, I noticed the instructions mention “Swipe gesture to close keyboard”, but that’s not how the keyboard is hidden. It’s actually hidden as soon as you touch the screen. The swiping then navigates back to the previous site. I assume that’s not what you want, because the Swipe gesture to close keyboard - Site test might not show the URL, for example. Right?

[malmstein]

Yes @0nko , you are right!

[0nko]

Works as expected, nice work @malmstein!

[malmstein]

Thanks for the review @0nko !