Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect listeners invoked in dialogs #5203

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Fix incorrect listeners invoked in dialogs #5203

merged 2 commits into from
Oct 28, 2024

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Oct 28, 2024 •
edited by nalcalag
Loading

Task/Issue URL: https://app.asana.com/0/1205648422731273/1208638453759884/f

Description

Steps to test this PR

TextAlertDialog

  • Navigate to Settings -> Appearance
  • Tap on "Force Websites To Use Dark Theme"
  • In the dialog, tap "Relaunch Now"
  • Verify that the app was restarted

RadioListAlertDialog

  • Navigate to Settings -> Fire Button
  • Tap on "Automatically Clear..."
  • In the dialog, change selected option and tap "Save"
  • Verify that setting value in the UI has been updated

No UI changes

@lmac012
Copy link
Contributor Author

lmac012 commented Oct 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lmac012 and the rest of your teammates on Graphite Graphite

@lmac012 lmac012 requested a review from malmstein October 28, 2024 16:47
@lmac012 lmac012 marked this pull request as ready for review October 28, 2024 16:47
@lmac012 lmac012 requested a review from nalcalag as a code owner October 28, 2024 16:47
@nalcalag nalcalag self-assigned this Oct 28, 2024
nalcalag
nalcalag approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙌

@lmac012 lmac012 merged commit b56381f into develop Oct 28, 2024
8 checks passed
@lmac012 lmac012 deleted the fix/lukasz/text-alert-dialog-on-click-listener branch October 28, 2024 18:36
aitorvs pushed a commit that referenced this pull request Nov 6, 2024
@lmac012 @aitorvs
Fix incorrect listeners invoked in dialogs (#5203)
f6e602a 
Task/Issue URL:
https://app.asana.com/0/1205648422731273/1208638453759884/f

### Description

### Steps to test this PR

_TextAlertDialog_
- [x] Navigate to Settings -> Appearance
- [x] Tap on "Force Websites To Use Dark Theme"
- [x] In the dialog, tap "Relaunch Now" 
- [x] Verify that the app was restarted

_RadioListAlertDialog_
- [x] Navigate to Settings -> Fire Button
- [x] Tap on "Automatically Clear..."
- [x] In the dialog, change selected option and tap "Save"
- [x] Verify that setting value in the UI has been updated


### No UI changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalcalag nalcalag nalcalag approved these changes

@malmstein malmstein Awaiting requested review from malmstein malmstein is a code owner

Assignees

@nalcalag nalcalag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmac012 @nalcalag @malmstein