Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Add Git Permission #5181

Merged
merged 13 commits into from
Oct 28, 2024

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Oct 24, 2024

Copy link
Contributor Author

malmstein commented Oct 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite Graphite

@malmstein malmstein force-pushed the feature/david/10-24-gha_ignore_fastlane_files branch from 9a9c10e to 92d1f0d Compare October 24, 2024 13:10
@malmstein malmstein changed the title GHA: ignore fastlane files GHA: Add Git Permission Oct 24, 2024
@malmstein malmstein marked this pull request as ready for review October 24, 2024 13:29
fastlane/Fastfile Outdated Show resolved Hide resolved
@malmstein malmstein force-pushed the feature/david/10-24-gha_ignore_fastlane_files branch from 6ed1ad4 to 4896ac0 Compare October 24, 2024 19:46
@malmstein
Copy link
Contributor Author

@aitorvs this is now tested using proper git credentials. We can now bypass the branch protection because we are using the gh token accordingly.

Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@malmstein malmstein merged commit a5553a9 into develop Oct 28, 2024
7 checks passed
@malmstein malmstein deleted the feature/david/10-24-gha_ignore_fastlane_files branch October 28, 2024 12:47
aitorvs added a commit that referenced this pull request Nov 6, 2024
Task/Issue URL:
https://app.asana.com/0/1174433894299346/1208617452367951/f

### Description
Add push permissions to GHA 

Working as per
https://github.com/duckduckgo/Android/actions/runs/11507256944/job/32033015991

---------

Co-authored-by: Aitor Viana <aitorvs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants