[Feature Toggle, Autofill.js] Pass through a js feature toggle for autofill #4955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205996472158114/1208150709359290/f
Description
This PR passes through remote config so that it can be accessed in
autofill.js
, no other business logic is added on the Android side. It's a simple pass-through.Remote config was already merged:
duckduckgo/privacy-configuration#2265
Autofill.js PR was already merged with the feature toggle:
duckduckgo/duckduckgo-autofill#619
Steps to test this PR
Fixes bugs like: https://app.asana.com/0/1200930669568058/1206749141089966/f
(With the latest remote config, already merged)
Counter test - do the same steps with an older config, with the
canCategorizeUnknownUsername
featuredisabled
. You won't see the key icon.E.g with https://jsonblob.com/api/1278747279446892544
UI changes
Autofill.js changes only, which were tested already in duckduckgo/duckduckgo-autofill#619