Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync option for getting app on other platforms #4895

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Aug 13, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1207997698739756/f

Description

Adds a new view with instructions on how to "Get DuckDuckGo on Other Devices" from the following places inside sync flows:

  • sync settings (sync disabled)
  • sync set up successfully screen
  • sync settings (sync enabled)

Steps to test this PR

When sync is disabled

  • With sync disabled, visit Sync & Backup screen; verify you see "Get DuckDuckGo on Other Devices" button
  • Tap on it, verify you see the new screen to get or share DDG link

Upon sync set up successfully

  • With sync disabled, visit Sync & Backup screen
  • Choose to Sync and Back Up This Device and complete sync flow
  • On the Your data is synced success screen, verify you see the new "Get DuckDuckGo on Other Devices" secondary button
  • Tap on it, verify you see the new screen to get or share DDG link

When sync is enabled

  • With sync enabled, visit Sync & Backup screen; verify you see "Get DuckDuckGo on Other Devices" button
  • Tap on it, verify you see the new screen to get or share DDG link

Testing the new screen works as expected

  • From the new screen to get or share DDG link, tap the Share Download Link button; verify you get a share dialog.
  • Choose to share it (e.g., to Messages or Gmail). Verify the message shared contains the link and, when tapped, opens the app download page
  • Return to the new screen to get or share DDG link; tap the blue hyperlink; verify the link is copied to the device cliipboard

UI changes

Various places from sync flow where there is a button to get to the new screen

New screen

Copy link
Member Author

CDRussell commented Aug 13, 2024

@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch 2 times, most recently from 3ce899b to 175e337 Compare August 14, 2024 10:10
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from eda89a1 to 01ce0ea Compare August 14, 2024 11:14
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 175e337 to bb6caf4 Compare August 14, 2024 11:14
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 01ce0ea to 52fe95c Compare August 16, 2024 12:50
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch 2 times, most recently from 8aa191a to cce54e9 Compare August 16, 2024 15:53
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 52fe95c to acbfbc5 Compare August 19, 2024 11:10
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from cce54e9 to 3939e8e Compare August 19, 2024 11:10
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from acbfbc5 to 1c79201 Compare August 19, 2024 11:55
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 3939e8e to bc820f3 Compare August 19, 2024 11:55
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 1c79201 to 9cc7b41 Compare August 19, 2024 12:08
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from bc820f3 to e8c3aba Compare August 19, 2024 12:08
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 9cc7b41 to 8a6e535 Compare August 19, 2024 12:57
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from e8c3aba to 20903f8 Compare August 19, 2024 12:57
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 8a6e535 to f2b674a Compare August 19, 2024 13:46
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 20903f8 to 0e01e9a Compare August 19, 2024 13:46
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from f2b674a to 6bfcf9b Compare August 19, 2024 13:50
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 0e01e9a to b98b776 Compare August 19, 2024 13:50
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 6bfcf9b to e7b9e1c Compare August 19, 2024 14:37
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch 2 times, most recently from 206a554 to 3440d88 Compare August 19, 2024 14:49
@CDRussell CDRussell marked this pull request as ready for review August 19, 2024 15:02
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 3440d88 to 69e8650 Compare August 20, 2024 09:05
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from e7b9e1c to 1125440 Compare August 20, 2024 10:18
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 69e8650 to dd8c248 Compare August 20, 2024 10:19
@CDRussell CDRussell mentioned this pull request Aug 20, 2024
29 tasks
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch 2 times, most recently from 2108e9a to 2602735 Compare August 20, 2024 16:10
@CDRussell CDRussell requested a review from karlenDimla August 20, 2024 16:11
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 1125440 to 036ff5e Compare August 20, 2024 16:13
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 2602735 to d54177c Compare August 20, 2024 16:13
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from d54177c to 7715e1b Compare August 21, 2024 11:11
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 036ff5e to d62592f Compare August 23, 2024 09:56
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 7715e1b to 3b30de8 Compare August 23, 2024 09:56
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from d62592f to 79ad68e Compare August 23, 2024 11:11
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch 3 times, most recently from 0ef0d3b to 6b99f83 Compare August 27, 2024 08:38
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_ui branch from 79ad68e to c977e24 Compare August 27, 2024 08:38
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from 6b99f83 to ab15c0a Compare August 27, 2024 08:38
Copy link
Member Author

CDRussell commented Aug 29, 2024

Merge activity

  • Aug 29, 11:58 AM EDT: @CDRussell started a stack merge that includes this pull request via Graphite.
  • Aug 29, 12:17 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 29, 12:31 PM EDT: @CDRussell merged this pull request with Graphite.

@CDRussell CDRussell changed the base branch from feature/craig/sync_promotion_ui to graphite-base/4895 August 29, 2024 16:00
@CDRussell CDRussell changed the base branch from graphite-base/4895 to develop August 29, 2024 16:14
@CDRussell CDRussell force-pushed the feature/craig/sync_promotion_app_download_links branch from ab15c0a to 1ab3d43 Compare August 29, 2024 16:16
@CDRussell CDRussell merged commit 1e0a1b2 into develop Aug 29, 2024
6 checks passed
@CDRussell CDRussell deleted the feature/craig/sync_promotion_app_download_links branch August 29, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants