-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync option for getting app on other platforms #4895
Merged
CDRussell
merged 1 commit into
develop
from
feature/craig/sync_promotion_app_download_links
Aug 29, 2024
Merged
Add sync option for getting app on other platforms #4895
CDRussell
merged 1 commit into
develop
from
feature/craig/sync_promotion_app_download_links
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2024
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on |
3ce899b
to
175e337
Compare
eda89a1
to
01ce0ea
Compare
175e337
to
bb6caf4
Compare
01ce0ea
to
52fe95c
Compare
8aa191a
to
cce54e9
Compare
52fe95c
to
acbfbc5
Compare
cce54e9
to
3939e8e
Compare
acbfbc5
to
1c79201
Compare
3939e8e
to
bc820f3
Compare
1c79201
to
9cc7b41
Compare
bc820f3
to
e8c3aba
Compare
9cc7b41
to
8a6e535
Compare
e8c3aba
to
20903f8
Compare
8a6e535
to
f2b674a
Compare
20903f8
to
0e01e9a
Compare
f2b674a
to
6bfcf9b
Compare
0e01e9a
to
b98b776
Compare
6bfcf9b
to
e7b9e1c
Compare
206a554
to
3440d88
Compare
3440d88
to
69e8650
Compare
e7b9e1c
to
1125440
Compare
69e8650
to
dd8c248
Compare
karlenDimla
reviewed
Aug 20, 2024
...nc-impl/src/main/java/com/duckduckgo/sync/impl/promotion/SyncGetOnOtherPlatformsViewModel.kt
Outdated
Show resolved
Hide resolved
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/ui/SyncActivity.kt
Show resolved
Hide resolved
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/ui/setup/SetupAccountActivity.kt
Show resolved
Hide resolved
29 tasks
2108e9a
to
2602735
Compare
1125440
to
036ff5e
Compare
2602735
to
d54177c
Compare
karlenDimla
approved these changes
Aug 20, 2024
d54177c
to
7715e1b
Compare
CDRussell
commented
Aug 21, 2024
...ync-impl/src/main/java/com/duckduckgo/sync/impl/promotion/SyncGetOnOtherPlatformsActivity.kt
Show resolved
Hide resolved
036ff5e
to
d62592f
Compare
7715e1b
to
3b30de8
Compare
d62592f
to
79ad68e
Compare
0ef0d3b
to
6b99f83
Compare
79ad68e
to
c977e24
Compare
6b99f83
to
ab15c0a
Compare
Merge activity
|
ab15c0a
to
1ab3d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207997698739756/f
Description
Adds a new view with instructions on how to "Get DuckDuckGo on Other Devices" from the following places inside sync flows:
Steps to test this PR
When sync is disabled
Upon sync set up successfully
When sync is enabled
Testing the new screen works as expected
UI changes
Various places from sync flow where there is a button to get to the new screen
New screen