Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Privacy Dashboard to 5.0.0 #4827

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

mgurgel
Copy link
Collaborator

@mgurgel mgurgel commented Jul 31, 2024

Task/Issue URL: https://app.asana.com/0/1206594217596623/1207921337238327/f

Description

Bumps Privacy Dashboard version to 5.0.0 with changes to the gray state

Parent task: https://app.asana.com/0/72649045549333/1207737672183274/f

TL;DR: Introduces a new green state to the Privacy Dashboard for when nothing is blocked and only affiliated domains are allowlisted. Updates the copy of the existing gray state. There are no changes on the native side.

Steps to test this PR

Repeat the steps for each of the sites in the table below:

  1. Visit [URL]
  2. Open Privacy Dashboard
  3. Check that dashboard screen is similar to [Screenshot]
  4. Check that [Things to note] are all true
  5. Click dashboard nav links (e.g. "Connection is encrypted", "Third party requests loaded") to check that they're working
URL Screenshot Things to note
https://ebay.de Screenshot 2024-08-01 at 15 37 45 - Icon shows green checkmark
- "No Tracking Requests Found" nav link is NOT visible
https://amazon.co.uk Screenshot 2024-08-01 at 15 38 45 - Icon shows red exclamation icon
- "No Tracking Requests Found" nav link is NOT visible
https://reddit.com Screenshot 2024-08-01 at 15 35 45 - Icon shows grey info icon
- "No Tracking Requests Found" nav link is NOT visible
https://cnn.com Screenshot 2024-08-01 at 15 37 30 - Multiple blocked icons shown
- "Requests Blocked from Loading" nav link IS visible

Notes

If any of the sites below do not show the expected screens, try refreshing the page, as trackers may be loaded alternately on reload. If the issue persists, please comment below with which sites had a mismatch. It doesn't mean the dashboard is broken, but it does mean I'll have to find a different site to test that screen. Different platforms may load different blockers, which leads to the dashboard not always showing the same status across all platforms and device configurations.

@karlenDimla
Copy link
Contributor

@mgurgel here are my findings:

  • https://ebay.de/ -> Shows blocked icon + Requests Blocked from Loading item is checked and shown.
  • https://amazon.co.uk/ -> almost looks as expected, but I dont see Cookies Managed even if I saw the cookies managed prompt in the icon.
  • https://reddit.com/ -> shows blocked icon + Requests Blocked from Loading item is checked and shown. No cookies managed item.
  • https://cnn.com/ -> almost looks as expected, but I dont see Cookies Managed

@mgurgel
Copy link
Collaborator Author

mgurgel commented Aug 6, 2024

Thanks for checking, @karlenDimla! The absence of cookies managed shouldn’t be a problem. As for the ones that show blocked when they shouldn’t, here’s a few more sites you could try. They should at least show the grey state.

https://text.marvinborner.de/2024-04-16-10.html
https://www.grulic.org.ar/~mdione/glob/posts/writing-a-tile-server-in-python/
https://www.codethink.co.uk/articles/2024/secure_bootloader/

In any case, @shakyShane says these states shouldn’t be a blocker.

@mgurgel mgurgel merged commit fd70934 into develop Aug 7, 2024
8 checks passed
@mgurgel mgurgel deleted the mgurgel/bump-privacy-dashboard-5_0_0 branch August 7, 2024 17:26
@lmac012 lmac012 mentioned this pull request Aug 23, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants