Update mockito to 5.12.0 and fix failing tests #4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on |
CDRussell
commented
Jul 2, 2024
| } | ||
|
|
||
| private fun fakeIntent(): Intent { | ||
| return Intent().also { it.addFlags(FLAG_ACTIVITY_NEW_TASK) } |
There was a problem hiding this comment.
needed otherwise ContextCompat.startActivities complains about the activity being started outside of an activity context. (in production, it's already using an activity context so no changes needed to prod code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207701481229686/1207716076931920/f
Description
Updates Mockito to latest version. This lets us run the tests on all Android APIs instead of being limited to ~API 30 like we are now.
Steps to test this PR