Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show host in download confirmation dialog #4706

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Jul 1, 2024

Task/Issue URL: https://app.asana.com/0/1142021229838617/1207476479082856/f

Description

This PR modifies the download confirmation dialog to show host extracted from download url.

Steps to test this PR

  • Smoke test triggering file download on a few different sites.

UI changes

Before After
Screenshot_20240703_130800 Screenshot_20240703_130346

@lmac012
Copy link
Contributor Author

lmac012 commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lmac012 and the rest of your teammates on Graphite Graphite

@lmac012 lmac012 force-pushed the feature/lukasz/show-host-in-download-dialog branch from b4a7138 to e8ad85d Compare July 3, 2024 11:41
@lmac012 lmac012 marked this pull request as ready for review July 3, 2024 12:17
@lmac012 lmac012 requested a review from anikiki July 3, 2024 12:53
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@lmac012 lmac012 merged commit 7a5c312 into develop Jul 4, 2024
6 checks passed
@lmac012 lmac012 deleted the feature/lukasz/show-host-in-download-dialog branch July 4, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants