Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds error pixel when compress fails #4522

Merged
merged 2 commits into from
May 13, 2024

Conversation

cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented May 8, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1207259077953491/f

Description

Debug pixel in case of failure when trying to compress patch

Steps to test this PR

Feature 1

  • Hardcode an error in Gzip interceptor
  • Run the app
  • Ensure pixel is sent
  • Ensure patch continues without compression

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @cmonfortep and the rest of your teammates on Graphite Graphite

@cmonfortep cmonfortep force-pushed the feature/cristian/sync/add_compression_error_pixel branch from 780e568 to 5a487b2 Compare May 8, 2024 09:51
@cmonfortep cmonfortep force-pushed the feature/cristian/sync/add_compression_error_pixel branch from 5a487b2 to 3dd0df7 Compare May 13, 2024 13:53
@cmonfortep cmonfortep merged commit ed286a1 into develop May 13, 2024
5 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/sync/add_compression_error_pixel branch May 13, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants