-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native crash handling #4517
Native crash handling #4517
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5eb6f4d
to
2f0e4de
Compare
2f0e4de
to
db2487f
Compare
1bd7855
to
3c64082
Compare
3c64082
to
318f7ec
Compare
318f7ec
to
ed2641e
Compare
Tried testing with the patch; it crashes but i'm not seeing any pixels (not in logcat nor kibana). Will wait until we get a chance to pair to look more into it as I might be doing something wrong in the testing, but heads up in case you know why this might be the case, @aitorvs |
We can take a look tomorrow. I used the patches and could crash and see the pixels in kibana. Gonna run this on emulator as well to see if there's any difference (been running it in pixel 4XL) |
private val nativeCrashFeature: NativeCrashFeature, | ||
) : MainProcessLifecycleObserver { | ||
|
||
private val isCustomTab: Boolean by lazy { customTabDetector.isCustomTab() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is lazily-init'd but the class is a singleton; won't it pick up whether it was a custom tab first time and cache that value thereafter regardless of whether custom tab state changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still unsure about custom tab param (see comment), but otherwise, LGTM
Task/Issue URL: https://app.asana.com/0/488551667048375/1207205378744694/f
Description
Add native crash handler and basic reporting
Steps to test this PR
Test native crash handing
Native crash handler init pixel sent
appears in logcatNative crash handler successfully initialized.
apperas in logcatNative crash pixel sent
appears in logcatpixel:m.app*.native.crash.*
main
process name, rightappVersion
and rightcustomTab
true/false value