Enforce declaredMethods order when evaluating FFs

[aitorvs]

Task/Issue URL: https://app.asana.com/0/488551667048375/1206628523510268/f

Description

See task for full context explanation

Steps to test this PR

Test

• install from this branch and launch the app
• go to app settings -> developer settings -> override privacy remote config URL
• toggle "use custom URL" on and enter https://jsonblob.com/api/jsonBlob/1126094951384629248
• tap on force reloading
• Use AS (or Flipper) to see the contents of the share prefs com.duckduckgo.feature.toggle.androidBrowserConfig
• take note of the hash
  -- repeat 3 times --
• force close the app and re-launch
• Use AS (or Flipper) to see the contents of the share prefs com.duckduckgo.feature.toggle.androidBrowserConfig
• verify the hash is the same
  -- END repeat 3 times --
• take note of the sate (enabled/disabled) of the androidBrowserConfig sub-features
• Go to https://www.jsonblob.com/1126094951384629248 and modify the hash of androidBrowserConfig
• force close the app and re-launch
• verify the hash is the same
• Go to https://www.jsonblob.com/1126094951384629248 and increase the version
• force close the app and re-launch
• verify the hash is different this time, and take note of it
• verify the state of the sub-features has not change
• Apply the following patch and rebuild / re-install / re-launch the app

Index: app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt b/app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt
--- a/app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt	(revision 5fe8bd5216708fbbe945832377600bc90233eb24)
+++ b/app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt	(date 1707729280159)
@@ -59,4 +59,7 @@
      */
     @Toggle.DefaultValue(false)
     fun optimizeTrackerEvaluation(): Toggle
+
+    @Toggle.DefaultValue(false)
+    fun testFlag(): Toggle
 }

• verify the androidBrowserConfig_testFlag is now present in the com.duckduckgo.feature.toggle.androidBrowserConfig and its enable value is most likely true (rolloutThreshold < 98)
• verify the hash has changed

[aitorvs]

• Enforce declaredMethods order when evaluating FFs #4193 👈
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on Graphite

[CrisBarreiro]

@aitorvs I'm stuck at verify the hash is different this time, and take note of it, I changed the hash for the jsonblob, but the hash on sharedPrefs wasn't updated. It was only after forcing config to be reloaded in developer settings that the hash was finally updated

[aitorvs]

@aitorvs I'm stuck at verify the hash is different this time, and take note of it, I changed the hash for the jsonblob, but the hash on sharedPrefs wasn't updated. It was only after forcing config to be reloaded in developer settings that the hash was finally updated

I had missed a test step, just added it and also expanded the verifications to double check something else.

[CrisBarreiro]

Looks good and works as expected!