Skip to content

Conversation

@aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Nov 8, 2023

Task/Issue URL: https://app.asana.com/0/488551667048375/1205898947038457/f

Description

Generalize the pixel param removal interceptor, migrate existing users and remove duplicate interceptors

Steps to test this PR

QA optional, just code review

@aitorvs
Copy link
Collaborator Author

aitorvs commented Nov 8, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@aitorvs aitorvs force-pushed the feature/aitor/pixel_param_removal branch from a3de043 to 9a393a2 Compare November 8, 2023 12:58
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aitorvs aitorvs merged commit a15a7ed into develop Nov 8, 2023
@aitorvs aitorvs deleted the feature/aitor/pixel_param_removal branch November 8, 2023 13:27

companion object {
fun removeAll() = setOf(ATB, APP_VERSION)
fun removeAtb() = setOf(APP_VERSION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should that be ATB?

aitorvs added a commit that referenced this pull request Nov 8, 2023
Task/Issue URL: https://app.asana.com/0/488551667048375/1205898947038457/f

### Description
Generalize the pixel param removal interceptor, migrate existing users and remove duplicate interceptors

### Steps to test this PR
QA optional, just code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants