Minimise use of default() dispatcher #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
cmonfortep
force-pushed
the
feature/cristian/stop_using_default
branch
from
5ad4cd2 to
3768271
Compare
This was referenced Oct 25, 2023
cmonfortep
requested review from
CDRussell,
karlenDimla,
joshliebe,
aitorvs and
malmstein
cmonfortep
force-pushed
the
feature/cristian/stop_using_default
branch
from
3768271 to
b65f3eb
Compare
CDRussell
approved these changes
Nov 9, 2023
| @@ -157,7 +157,7 @@ class SearchAndFavoritesWidget : AppWidgetProvider() { | |||
| voiceSearchWidgetConfigurator.configureVoiceSearch(context, remoteViews, true) | |||
| configureFavoritesGridView(context, appWidgetId, remoteViews, widgetTheme) | |||
| configureEmptyWidgetCta(context, appWidgetId, remoteViews, widgetTheme) | |||
|
|
|||
| // TODO: can this be moved to io? | |||
There was a problem hiding this comment.
is this TODO deliberately to remain?
malmstein
approved these changes
Nov 10, 2023
karlenDimla
approved these changes
Nov 10, 2023
joshliebe
approved these changes
Nov 11, 2023
cmonfortep
force-pushed
the
feature/cristian/stop_using_default
branch
from
b65f3eb to
3966b5b
Compare
cmonfortep
force-pushed
the
feature/cristian/stop_using_default
branch
from
3966b5b to
9a65ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1205529944668184/f
Description
Migrates away from using Dispatcher.Default(). That applies to any
launchin appCoroutineScope or custom scope where no dispatcher has been defined.Steps to test this PR
Smoke tests in the app
UI changes