Add support for privacy config v4 #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
marcosholgado
force-pushed
the
feature/marcos/privacy_config_v4
branch
6 times, most recently
from
eb1d5af to
2c91eee
Compare
aitorvs
approved these changes
Oct 13, 2023
| data class AdClickAttributionFeature( | ||
| val state: String, | ||
| val minSupportedVersion: Int?, | ||
| val settings: AdClickAttributionSettings, | ||
| val exceptions: List<AdClickAttributionException>, | ||
| val exceptions: List<FeatureException>, |
There was a problem hiding this comment.
Nit: to be clear, this is fine.
It feels odd for now because all these features (ad-click) etc related to the privacy-config module but take the model from the feature-toggles module.
No need to change, just a comment
| @@ -31,6 +31,7 @@ kotlin { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation project(path: ':feature-toggles-api') | |||
There was a problem hiding this comment.
Yeah, that's what I was saying before. Maybe we want a PrivacyConfigException instead of using the FeatureException.
No strong opinions tbh. I think long term we want to migrate everything to use the feature-toggles module
marcosholgado
force-pushed
the
feature/marcos/privacy_config_v4
branch
from
2c91eee to
626ced6
Compare
joshliebe
pushed a commit
that referenced
this pull request
Nov 7, 2023
Task/Issue URL: https://app.asana.com/0/1202552961248957/1205690187399816/f ### Description Add support for remote config v4 ### Steps to test this PR _Update_ - [ ] Install from develop - [ ] Check the DB for the different features (privacy_config.db, autoconsent, autofill, cookies, etc). Go to the different exceptions tables and seen that the column for reasons has content - [ ] Update from this branch - [ ] The app should not crash - [ ] Check the DBs and the reason column should now be null but domains should still be there. _New install_ - [ ] Install from this branch - [ ] The app should not crash - [ ] Check the DBs and the reason column should now be null but domains should still be there. _Tests_ - [ ] Privacy Tests should pass, see https://github.com/duckduckgo/Android/actions/runs/6510081560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202552961248957/1205690187399816/f
Description
Add support for remote config v4
Steps to test this PR
Update
New install
Tests