Create ua module and move ua classes #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
marcosholgado
force-pushed
the
feature/marcos/create_ua_module
branch
from
a735d22 to
22bc2f5
Compare
joshliebe
reviewed
Sep 18, 2023
| @@ -0,0 +1,63 @@ | |||
| /* | |||
| * Copyright (c) 2021 DuckDuckGo | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2021 DuckDuckGo | |
| * Copyright (c) 2023 DuckDuckGo |
joshliebe
reviewed
Sep 18, 2023
| @@ -0,0 +1,35 @@ | |||
| /* | |||
| * Copyright (c) 2021 DuckDuckGo | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2021 DuckDuckGo | |
| * Copyright (c) 2023 DuckDuckGo |
joshliebe
pushed a commit
that referenced
this pull request
Nov 7, 2023
Task/Issue URL: https://app.asana.com/0/488551667048375/1205489571133516/f ### Description This PR moves the ua provider and plugin to its own module ### Steps to test this PR - [x] With internal flavour test that all the UA are correctly set. - [x] Filter the logcat by `user agent is` - [x] Go to `digid.nl`, UA should not have the duckduckgo component - [x] Go to `marvel.com` UA should not have the duckduckgo component or version - [x] Go to `whitepages.com` UA should not have the version component - [x] Go to `reddit.com` UA should be the WebView default - [x] Go to `duckduckgo.com` UA should be our custom one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1205489571133516/f
Description
This PR moves the ua provider and plugin to its own module
Steps to test this PR
user agent isdigid.nl, UA should not have the duckduckgo componentmarvel.comUA should not have the duckduckgo component or versionwhitepages.comUA should not have the version componentreddit.comUA should be the WebView defaultduckduckgo.comUA should be our custom one