Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to point to new privacy page URL #3527

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Sep 12, 2023

Task/Issue URL: https://app.asana.com/0/488551667048375/1205442219109577/f

Description

Updates the URLs for the privacy test pages since we've moved them to new infrastructure.

Current: privacy-test-pages.glitch.me
New: privacy-test-pages.site

ℹ️ Note, global-privacy-control.glitch.me remains deliberately, as per link

Steps to test this PR

@CDRussell
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CDRussell CDRussell merged commit cf836bd into develop Sep 20, 2023
@CDRussell CDRussell deleted the feature/craig/Update_tests_to_point_to_new_privacy_page_URL branch September 20, 2023 09:11
joshliebe pushed a commit that referenced this pull request Nov 7, 2023
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
If your PR does not involve UI changes, you can remove the **UI
changes** section

At a minimum, make sure your changes are tested in API 23 and one of the
more recent API levels available.
-->

Task/Issue URL:
https://app.asana.com/0/488551667048375/1205442219109577/f

### Description
Updates the URLs for the privacy test pages since we've moved them to
new infrastructure.

`Current: privacy-test-pages.glitch.me`
`New:     privacy-test-pages.site`

ℹ️ Note, `global-privacy-control.glitch.me` remains deliberately, as per
[link](https://app.asana.com/0/0/1205403548898249/1205420985241292/f)

### Steps to test this PR

- [ ] Ensure maestro e2e tests pass
(https://github.com/duckduckgo/Android/actions/runs/6157390651)
- [ ] Ensure privacy tests passed
(https://github.com/duckduckgo/Android/actions/runs/6223122120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants