Skip to content

Conversation

laghee
Copy link
Collaborator

@laghee laghee commented Aug 22, 2023

Task/Issue URL: https://app.asana.com/0/488551667048375/1205311544271092/f

Description

In an oversight, I forgot to apply the changes made in #3439 to the AppTP breakage form as well, so taking care of that now.

Steps to test this PR

  • Enter AppTP reporting flow for a broken app
  • Confirm that entire textview is clickable to select the breakage category rather than only the end icon

@laghee laghee requested a review from anikiki August 22, 2023 18:02
@anikiki anikiki self-assigned this Aug 23, 2023
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@laghee laghee merged commit 0fbe697 into develop Aug 23, 2023
@laghee laghee deleted the fix/kate/extend-clickable-area-apptp-breakage-category branch August 23, 2023 10:28
joshliebe pushed a commit that referenced this pull request Nov 7, 2023
…3485)

<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
If your PR does not involve UI changes, you can remove the **UI
changes** section

At a minimum, make sure your changes are tested in API 23 and one of the
more recent API levels available.
-->

Task/Issue URL:
https://app.asana.com/0/488551667048375/1205311544271092/f

### Description
In an oversight, I forgot to apply the changes made in
#3439 to the AppTP breakage
form as well, so taking care of that now.

### Steps to test this PR
- [x] Enter AppTP reporting flow for a broken app
- [x] Confirm that entire textview is clickable to select the breakage
category rather than only the end icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants