Move privacy maestro test to use tags #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
aitorvs
force-pushed
the
cleanup/aitor/maestro/privacy_tests
branch
from
d4bc4ad to
c45d137
Compare
aitorvs
commented
Aug 15, 2023
| @@ -21,7 +21,7 @@ jobs: | |||
| - name: Set up JDK 11 | |||
| uses: actions/setup-java@v3 | |||
| with: | |||
| java-version: '11' | |||
| java-version: '17' | |||
There was a problem hiding this comment.
This should have been 17 always, probably sync tests never ran
aitorvs
changed the base branch from
develop
to
fix/aitor/EncryptedSharedPrefsProvider
aitorvs
force-pushed
the
cleanup/aitor/maestro/privacy_tests
branch
from
c45d137 to
4421b91
Compare
Base automatically changed from
fix/aitor/EncryptedSharedPrefsProvider
to
develop
August 15, 2023 13:52
aitorvs
force-pushed
the
cleanup/aitor/maestro/privacy_tests
branch
from
4421b91 to
b9671b7
Compare
aitorvs
force-pushed
the
cleanup/aitor/maestro/privacy_tests
branch
from
b9671b7 to
b0b1b53
Compare
aitorvs
commented
Aug 15, 2023
| @@ -9,6 +9,7 @@ appId: com.duckduckgo.mobile.android | |||
| - tapOn: "Allow" | |||
| - assertVisible: | |||
| text: ".*Welcome to DuckDuckGo!.*" | |||
| optional: true | |||
There was a problem hiding this comment.
Adding optional because this is flaky in CI and anyways it's optional step
aitorvs
commented
Aug 15, 2023
| @@ -9,6 +9,7 @@ appId: com.duckduckgo.mobile.android | |||
| - tapOn: "Don’t allow" | |||
| - assertVisible: | |||
| text: ".*Welcome to DuckDuckGo!.*" | |||
| optional: true | |||
There was a problem hiding this comment.
Adding optional because this is flaky in CI and anyways it's optional step
joshliebe
pushed a commit
that referenced
this pull request
Nov 7, 2023
Task/Issue URL: https://app.asana.com/0/0/1205258019391734/f ### Description Move e2e privacy test to use shared onboarding flow, and use the tag `privacyTest` ### Steps to test this PR https://github.com/duckduckgo/Android/actions/runs/5868616041/job/15911849417 passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205258019391734/f
Description
Move e2e privacy test to use shared onboarding flow, and use the tag
privacyTestSteps to test this PR
https://github.com/duckduckgo/Android/actions/runs/5868616041/job/15911849417 passes