-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support shareable credentials across sites from same company #3397
Merged
CDRussell
merged 3 commits into
develop
from
feature/craig/Support_shareable_credentials_across_sites_from_same_company
Aug 7, 2023
Merged
Support shareable credentials across sites from same company #3397
CDRussell
merged 3 commits into
develop
from
feature/craig/Support_shareable_credentials_across_sites_from_same_company
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dde50d
to
7c0bcab
Compare
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
f9b32b2
to
e508c68
Compare
CDRussell
commented
Aug 2, 2023
cmonfortep
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
...l-impl/src/main/java/com/duckduckgo/autofill/impl/urlmatcher/AutofillDomainNameUrlMatcher.kt
Show resolved
Hide resolved
...ava/com/duckduckgo/autofill/impl/ui/credential/selecting/AutofillSelectCredentialsGrouper.kt
Outdated
Show resolved
Hide resolved
...duckduckgo/autofill/impl/ui/credential/selecting/RealAutofillSelectCredentialsGrouperTest.kt
Outdated
Show resolved
Hide resolved
.../com/duckduckgo/autofill/impl/ui/credential/management/viewing/AutofillManagementListMode.kt
Show resolved
Hide resolved
...n/java/com/duckduckgo/autofill/impl/ui/credential/management/suggestion/SuggestionMatcher.kt
Show resolved
Hide resolved
...l/src/main/java/com/duckduckgo/autofill/impl/sharedcreds/AppleSharedCredentialsJsonReader.kt
Outdated
Show resolved
Hide resolved
fe3291b
to
9aea324
Compare
Waiting on stable release of autofill to get published; will update to use it and merge when it's available (see also: #3397 (comment)) |
9aea324
to
4310b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1205182889422649/f
Description
Steps to test this PR
See Testing steps
UI changes