Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shareable credentials across sites from same company #3397

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Aug 1, 2023

Task/Issue URL: https://app.asana.com/0/488551667048375/1205182889422649/f

Description

  • Some companies share login details across different domains they own. For example, ebay.co.uk and ebay.com is, for autofill purposes, the same site.
  • With this change, we will offer up saved credentials which match across domains for a subset of top sites.

Steps to test this PR

See Testing steps

UI changes

Screenshot 2023-08-01 at 09 42 40

@CDRussell CDRussell force-pushed the feature/craig/Support_shareable_credentials_across_sites_from_same_company branch from 5dde50d to 7c0bcab Compare August 1, 2023 11:21
@CDRussell
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@CDRussell CDRussell force-pushed the feature/craig/Support_shareable_credentials_across_sites_from_same_company branch 5 times, most recently from f9b32b2 to e508c68 Compare August 2, 2023 10:37
@CDRussell CDRussell marked this pull request as ready for review August 2, 2023 11:23
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CDRussell CDRussell force-pushed the feature/craig/Support_shareable_credentials_across_sites_from_same_company branch 2 times, most recently from fe3291b to 9aea324 Compare August 7, 2023 11:07
@CDRussell
Copy link
Member Author

Waiting on stable release of autofill to get published; will update to use it and merge when it's available (see also: #3397 (comment))

@CDRussell CDRussell force-pushed the feature/craig/Support_shareable_credentials_across_sites_from_same_company branch from 9aea324 to 4310b8f Compare August 7, 2023 14:05
@CDRussell CDRussell merged commit 61a8de6 into develop Aug 7, 2023
@CDRussell CDRussell deleted the feature/craig/Support_shareable_credentials_across_sites_from_same_company branch August 7, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants