Use anchor links for add click maestro tests #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
marcosholgado
force-pushed
the
fix/marcos/maestro_ad_clicks_anchor
branch
from
26d1b6f to
5345bbf
Compare
|
@marcosholgado you can review the code changes. I'm still getting random failures on the end2end maestro tests but they are related with emulator connectivity issues. I will continue running them until it's green |
cmonfortep
approved these changes
Apr 18, 2023
|
Will see if this one passes: https://github.com/duckduckgo/Android/actions/runs/4732106281 |
|
LGTM! |
|
Finally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1204397066248823/f
Description
This PR changes the ad click maestro tests to use anchor links instead of scrolling
Steps to test this PR