Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change autofill subfeature names in prep for releasing #3053

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Apr 11, 2023

Task/Issue URL: https://app.asana.com/0/0/1204370666975082/f

Description

Renames the autofill subfeatures, as is required to prepare for the autofill release.

Steps to test this PR

Start with develop branch.

  • Checkout develop
  • Build using play variant, and do a clean install.
  • Give the app a few seconds after launching to fetch the remote config.
  • Verify that autofill is NOT visible (e.g., you cannot access the credential management screen)

Use new remote config
Change URL we use for the remote config (it's defined in PrivacyFeatureName.PRIVACY_REMOTE_CONFIG_URL)

  • change it to https://jsonblob.com/api/1095045267291652096
  • Make the above change to the URL in develop
  • Build usingplay variant again, and install the app.
  • Give the app a few seconds after launching to fetch the remote config.
  • Verify that autofill is still NOT visible (e.g., you cannot access the credential management screen)

Checkout the branch from this PR

  • Checkout the branch from this PR, and apply the URL change as above so it's getting the new remote config type
  • Install using play variant again.
  • Give the app a few seconds after launching to fetch the remote config.
  • Verify that autofill IS visible (e.g., you can access the credential management screen - you might need to launch a new tab to see it picked up in the overflow if you were already viewing a tab)
  • Verify that autofill is DISABLED by default ⚠️

@CDRussell
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@CDRussell CDRussell marked this pull request as ready for review April 11, 2023 13:32
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CDRussell CDRussell force-pushed the feature/craig/change_autofill_remote_config_feature_name branch from 01d8280 to 2dc8bac Compare April 12, 2023 11:35
@CDRussell
Copy link
Member Author

@marcosholgado, as discussed, pushed new commits to workaround the issue of autofill remote config block not being processed. re-review plz 🙏

@CDRussell CDRussell requested a review from marcosholgado April 12, 2023 11:54
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested including the edge case that we found. All working as expected 👍

@CDRussell CDRussell merged commit 363422f into develop Apr 12, 2023
@CDRussell CDRussell deleted the feature/craig/change_autofill_remote_config_feature_name branch April 12, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants