New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ANR when assigning AppTP cohort #3014

Merged

aitorvs merged 1 commit into develop from fix/aitor/atp/cohort_anr

Mar 29, 2023

Collaborator

aitorvs commented Mar 28, 2023 •

edited by karlenDimla

Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1204265639917299/f

Description

Ensure calls to CohortStore are not done in the main thread.

The approach taken is has been:

marking method as WorkerThread
in internal builds checkMainThread and throw
in production build we don't do the checkMainThread

Steps to test this PR

Check cohort is assigned

fresh install from this branch the internal build
open the app
enable AppTP
filter logcat with atp_cohort
navigate to AppTP exclusion list screen
verify pixels are fired with atp_cohort parameter assigned
repeat with play build

Smoke test AppTP as well is useful


          Prevent ANR when assigning AppTP cohort

1de0ec0

Collaborator Author

aitorvs commented Mar 28, 2023

Current dependencies on/for this PR:

develop
- PR Prevent ANR when assigning AppTP cohort #3014 👈

This comment was auto-generated by Graphite.

aitorvs assigned karlenDimla

karlenDimla approved these changes

View reviewed changes

aitorvs merged commit 81e7b0d into develop

aitorvs deleted the fix/aitor/atp/cohort_anr branch

March 29, 2023 11:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet