Skip to content

Followup: New temporary pixels for "Notify Me" component / Follow-up: remove parameter for Android13 #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Mar 24, 2023

Task/Issue URL:
https://app.asana.com/0/69071770703008/1203884929941926/f
https://app.asana.com/0/69071770703008/1203353347663734/f

Description

Removed temporary pixels added as part of notifications permissions changes on Android 13.

  • Pixel m_notify_me_component_notify_me_button_pressed (AppTP & Browser)
  • Pixel m_notify_me_component_close_button_pressed (AppTP & Browser)
  • Param os_version_13_or_above set from onboarding when default browser set / not set (Browser)

Steps to test this PR

DDG set as default browser

  • Install from this branch.
  • Filter logcat by Pixel sent.
  • Start onboarding and notice the Set DDG as default browser. Choose to set it.
  • Check that you see in the logs Pixel sent: m_db_s with params: {fo=true}. It does not contain the os_version_13_or_above param.

DDG NOT set as default browser + notify me

  • Install from this branch and don't allow notifications (if on Android 13, else disable notifications).
  • Filter logcat by Pixel sent.
  • Start onboarding and notice the Set DDG as default browser. Choose and set any other browser as default.
  • Check that you see in the logs Pixel sent: m_db_ns with params: {fo=true}. It does not contain the os_version_13_or_above param.
  • Go to the Downloads screen.
  • Notice the Notify Me component.
  • Tap on Notify Me button. Don't allow notifications.
  • Check that the m_notify_me_component_notify_me_button_pressed pixel is never sent.
  • Tap on the close button on Notify Me component.
  • Check that the m_notify_me_component_close_button_pressed pixel is never sent.
  • Enable AppTP.
  • Notice the Notify Me component.
  • Tap on Notify Me button. Don't allow notifications.
  • Check that the m_notify_me_component_notify_me_button_pressed pixel is never sent.
  • Tap on the close button on Notify Me component.
  • Check that the m_notify_me_component_close_button_pressed pixel is never sent.

NO UI changes

@CDRussell CDRussell self-assigned this Mar 27, 2023
@anikiki anikiki merged commit bd53e83 into develop Mar 28, 2023
@anikiki anikiki deleted the feature/ana/remove_parameter_for_android_13 branch March 28, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants