Followup: New temporary pixels for "Notify Me" component / Follow-up: remove parameter for Android13 #3007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
https://app.asana.com/0/69071770703008/1203884929941926/f
https://app.asana.com/0/69071770703008/1203353347663734/f
Description
Removed temporary pixels added as part of notifications permissions changes on Android 13.
m_notify_me_component_notify_me_button_pressed
(AppTP & Browser)m_notify_me_component_close_button_pressed
(AppTP & Browser)os_version_13_or_above
set from onboarding when default browser set / not set (Browser)Steps to test this PR
DDG set as default browser
Pixel sent
.Set DDG as default browser
. Choose to set it.Pixel sent: m_db_s with params: {fo=true}
. It does not contain theos_version_13_or_above
param.DDG NOT set as default browser + notify me
Pixel sent
.Set DDG as default browser
. Choose and set any other browser as default.Pixel sent: m_db_ns with params: {fo=true}
. It does not contain theos_version_13_or_above
param.Downloads
screen.Notify Me
component.Notify Me
button. Don't allow notifications.m_notify_me_component_notify_me_button_pressed
pixel is never sent.Notify Me
component.m_notify_me_component_close_button_pressed
pixel is never sent.Notify Me
component.Notify Me
button. Don't allow notifications.m_notify_me_component_notify_me_button_pressed
pixel is never sent.Notify Me
component.m_notify_me_component_close_button_pressed
pixel is never sent.NO UI changes