Onboarding Customisation Experiment

[nalcalag]

Task/Issue URL: https://app.asana.com/0/72649045549333/1203826977705495/f

Description

Implement Onboarding Customisation experiment where experimental group will see an extra onboarding dialog with DDG feature options.

Steps to test this PR

Change all variants to 0 except for the mj variant

New multiselect dialog

• Uninstall previous version of the app or clear storage
• Install from this branch
• Welcome animation will appear
• Check new dialog with DDG feature options appear

Skip selecting options

• Follow same instructions as "New multiselect dialog" test
• Tap on Skip This Step
• Check existing welcome cta dialog appears
• Check pixel m_onboarding_option_skip is fired

Continue without options selected

• Follow same instructions as "New multiselect dialog" test
• Tap on any option to select it
• Remove the selection tapping again
• Tap on Continue button
• Check existing welcome cta dialog appears
• Check pixel m_onboarding_option_skip is fired

Continue with options selected

• Follow same instructions as "New multiselect dialog" test
• Tap on one or more options to select them
• Tap on Continue button
• Check existing welcome cta dialog appears
• Check pixel m_onboarding_option_selected is fired
• Check pixels for each option selected is also fired. You can find the list of pixels for each option here -> https://app.asana.com/0/0/1204137437551040/f

UI changes

Screen_Recording_20230328_170114_DuckDuckGo.mp4

[nalcalag]

Current dependencies on/for this PR:

• develop
  • PR Onboarding Customisation Experiment #3003 👈

This comment was auto-generated by Graphite.

[malmstein]

Seeing that this is an experiment, and it's not sure that it will be permanent, I'd prefer that all modifications stay as contained as possible. That means, everything new, even colors and styles should stay in the app module. If and then this becomes permanent, then we follow the process of adding a new Component from ADS.

[cmonfortep]

LGTM

works as expected, leaving the UI discussion to the UI code owners 😁.

(Agree with David that new components should go through ADS standard process, however not clear if this is an established component atm. I assume we have some lint checks and that's why we put some colors inside common-ui, if that's the case, maybe we can do something similar to what we do with strings...have a separated file, or declare them under a comment that indicates they are not established. Just some thoughts)

[cmonfortep]

include one test for this?

[nalcalag]

I will 👌

[nalcalag]

@malmstein following @cmonfortep suggestion I added a new resource file called temp_colors.xml where I put all the colors needed for the customView because I need to add them to the theme file so they can change depending on the theme. I also migrated all styles and attributes to new resources files in the app module so they are not in common-ui anymore 🎉

@cmonfortep thanks a lot for all your feedback, I changed everything you suggested and added tests for portrait checks 👍

[malmstein]

Thanks for doing the changes @nalcalag. Good work!