-
Notifications
You must be signed in to change notification settings - Fork 1k
Encrypt device info on auth flows #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encrypt device info on auth flows #2948
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
} | ||
} | ||
|
||
private fun login( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was duplicated (probably from a previous merge)
|
||
data class DeviceType(val deviceFactor: String = "") { | ||
fun type(): Type { | ||
val mobileRegex = Regex("(phone|tablet)", RegexOption.IGNORE_CASE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe move outside of this function for reuse
Task/Issue URL: https://app.asana.com/0/1201493110486074/1203835825731590/f
Description
Encrypts device info (name and type) on all auth flows.
Also changes QR format to follow b64 encoding
Steps to test this PR
(you will need 2 devices to test some of the auth flows)
create account and login
connect (device B should have a camera)