Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Dark mode not respected in WebView #2884

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Feb 24, 2023

Task/Issue URL: https://app.asana.com/0/414730916066338/1204003071445738/f

Description

Updated to use the DayNight base theme. Increased webkit version. Added android:isLightTheme with appropriate values in both light and dark themes.

Fixes #2878

Steps to test this PR

Check the issue

  • Install from develop on a device with OS version 11+
  • Switch the theme to "Dark" / "System Default" (in this case make sure your phone had Dark mode ON) from Settings
  • Search for something (e.g cats)
  • Notice the search results page is light

Check the fix

  • Install from develop on a device with OS version 11+
  • Switch the theme to "Dark" / "System Default" (in this case make sure your phone had Dark mode ON) from Settings
  • Search for something (e.g cats)
  • Notice the search results page is dark

NO UI changes

Android 13

Android 13 - issue

…ed android:isLightTheme with appropriate values in both light and dark themes.
@anikiki anikiki marked this pull request as ready for review March 1, 2023 13:18
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for taking care of it.

@anikiki anikiki merged commit c125e3e into develop Mar 6, 2023
@anikiki anikiki deleted the fix/ana/bug_dark_mode_not_respected_in_webview branch March 6, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Recent Update breaks application dark theme setting
2 participants