Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppTP: Remove the kotlin-android-extensions plugin #2861

Merged

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Feb 17, 2023

Task/Issue URL: https://app.asana.com/0/1202279501986195/1203985450170811/f

Description

Removed kotlin-android-extensions plugin from AppTP code.

Steps to test this PR

  • Checkout this branch.
  • Do a ./gradlew clean assembleID or ./gradlew clean assemblePR. You should see it builds successfully.
  • [Optional] Open the app and enable App Tracking Protection. See everything works as expected.

NO UI changes

@joshliebe joshliebe self-assigned this Feb 17, 2023
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works, LGTM! 🙂

@anikiki anikiki merged commit 5bd56a4 into develop Feb 17, 2023
@anikiki anikiki deleted the feature/ana/apptp_remove_the_kotlin_android_extensions_plugin branch February 17, 2023 12:23
aitorvs pushed a commit that referenced this pull request Feb 24, 2023
Task/Issue URL: https://app.asana.com/0/1202279501986195/1203985450170811/f

### Description
Removed kotlin-android-extensions plugin from AppTP code.

### Steps to test this PR

- [x] Checkout this branch.
- [x] Do a `./gradlew clean assembleID` or `./gradlew clean assemblePR`. You should see it builds successfully. 
- [x] [Optional] Open the app and enable App Tracking Protection. See everything works as expected.

### NO UI changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants