Skip to content

FeatureFlag waitlist #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 21, 2023
Merged

FeatureFlag waitlist #2844

merged 5 commits into from
Feb 21, 2023

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Feb 15, 2023 •
edited by marcosholgado
Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1203935342025551/f

Description

Adds feature flag onto waitlist feature.

There are 2 entry points:

  • From macOS screen, if feature disabled, do not show link to waitlist
  • From settings screen, if feature disabled, do not show setting item

Steps to test this PR

Feature 1

  • In PrivacyFeatureName, replace PRIVACY_REMOTE_CONFIG_URL with https://jsonblob.com/api/jsonBlob/1075345853253959680
  • Fresh install
  • Go to settings, ensure no entry point to wd waitlist present
  • Go to macos settings, ensure no entry point to wd waitlist present

Feature 2

  • Fresh install
  • Go to settings, ensure entry point to wd waitlist is present
  • Go to macos settings, ensure entry point to wd waitlist present

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

This was referenced Feb 15, 2023
Merged
Merged
@cmonfortep
Copy link
Contributor Author

cmonfortep commented Feb 15, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@cmonfortep cmonfortep marked this pull request as ready for review February 15, 2023 11:00
marcosholgado
marcosholgado approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@cmonfortep cmonfortep force-pushed the feature/cristian/windows_waitlist_notifyme branch from 02375a6 to bf9d76b Compare February 17, 2023 10:15
@cmonfortep cmonfortep force-pushed the feature/cristian/windows_waitlist_featureflag branch from 746b7a8 to d8f85f2 Compare February 17, 2023 10:16
@cmonfortep cmonfortep force-pushed the feature/cristian/windows_waitlist_notifyme branch from bf9d76b to 9fdcb05 Compare February 17, 2023 11:13
@cmonfortep cmonfortep force-pushed the feature/cristian/windows_waitlist_featureflag branch from d8f85f2 to 7cce95f Compare February 17, 2023 11:14
@cmonfortep cmonfortep force-pushed the feature/cristian/windows_waitlist_notifyme branch from 9fdcb05 to 0da06e7 Compare February 17, 2023 12:47
@cmonfortep cmonfortep force-pushed the feature/cristian/windows_waitlist_featureflag branch from 7cce95f to e9811dc Compare February 17, 2023 12:47
@cmonfortep cmonfortep force-pushed the feature/cristian/windows_waitlist_notifyme branch from 0da06e7 to 80501b7 Compare February 17, 2023 12:51
@cmonfortep cmonfortep force-pushed the feature/cristian/windows_waitlist_featureflag branch from e9811dc to 223d739 Compare February 17, 2023 12:51
@cmonfortep cmonfortep merged commit 9ded596 into feature/cristian/windows_waitlist_notifyme Feb 21, 2023
@cmonfortep cmonfortep deleted the feature/cristian/windows_waitlist_featureflag branch February 21, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcosholgado marcosholgado marcosholgado approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmonfortep @marcosholgado