Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cohort when AppTP is enabled only #2842

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

karlenDimla
Copy link
Contributor

@karlenDimla karlenDimla commented Feb 15, 2023

Task/Issue URL: https://app.asana.com/0/488551667048375/1203973782879231/f

Description

This PR adds a check if AppTP is registered before updating the cohort.
See Asana task for more info.

Steps to test this PR

  • Fresh install build from this PR
  • Verify that logs show Pixel URL request dropped:
  • Enable AppTP
  • Verify that logs no longer sshow Pixel URL request dropped:

@karlenDimla
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@karlenDimla karlenDimla force-pushed the fix/karl/apptp-cohort-store branch from 96dd2b3 to 2bd1611 Compare February 15, 2023 08:19
Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karlenDimla karlenDimla merged commit 5a2c4b2 into develop Feb 15, 2023
@karlenDimla karlenDimla deleted the fix/karl/apptp-cohort-store branch February 15, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants