Fix NoSuchElementException in notification content plugin #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
karlenDimla
reviewed
Feb 9, 2023
| fun PluginPoint<VpnEnabledNotificationContentPlugin>.getHighestPriorityPlugin(): VpnEnabledNotificationContentPlugin { | ||
| return getPlugins().filter { it.isActive() }.maxBy { it.getPriority().ordinal } | ||
| fun PluginPoint<VpnEnabledNotificationContentPlugin>.getHighestPriorityPlugin(): VpnEnabledNotificationContentPlugin? { | ||
| return runCatching { getPlugins().filter { it.isActive() }.maxByOrNull { it.getPriority().ordinal } }.getOrNull() |
There was a problem hiding this comment.
Is it necessary to wrap this in runCatching? We can also add tests here to check.
There was a problem hiding this comment.
Just saw the explanation in Asana. 👍
aitorvs
force-pushed
the
fix/aitor/atp/notification_content_plugin
branch
2 times, most recently
from
805dadb to
412eb62
Compare
aitorvs
force-pushed
the
fix/aitor/atp/notification_content_plugin
branch
from
412eb62 to
30a9439
Compare
malmstein
pushed a commit
that referenced
this pull request
Feb 9, 2023
Task/Issue URL: https://app.asana.com/0/488551667048375/1203928902312895/f ### Description See [asana task](https://app.asana.com/0/488551667048375/1203928902312895/f) for description ### Steps to test this PR _AppTP Notifications_ - [x] fresh install from this branch - [x] launch app and enable AppTP - [x] verify ongoing notification shows and text is `Scanning for tracking activity… beep… boop` - [x] open any one app that tracks - [x] verify ongoing notification shows and text is `Tracking attempts blocked in 1 app (past hour).` - [x] open any second app that tracks - [x] verify ongoing notification shows and text is `Tracking attempts blocked across 2 apps (past hour).` - [x] Force close the app - [x] notification should disappear - [x] re-open app - [x] verify ongoing notification shows and text is `Tracking attempts blocked across 2 apps (past hour).` - [x] verify tapping on the notification takes the user to AppTP screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1203928902312895/f
Description
See asana task for description
Steps to test this PR
AppTP Notifications
Scanning for tracking activity… beep… boopTracking attempts blocked in 1 app (past hour).Tracking attempts blocked across 2 apps (past hour).Tracking attempts blocked across 2 apps (past hour).