Consume netguard as a dependency #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
aitorvs
force-pushed
the
feature/aitor/atp/netguard_lib
branch
from
6d857e0 to
281889a
Compare
aitorvs
commented
Dec 16, 2022
build.gradle
Outdated
Comment on lines
44
to
46
| // maven { | ||
| // url = uri("https://maven.pkg.github.com/duckduckgo/netguard") | ||
| // } |
There was a problem hiding this comment.
I will delete this in the final version
aitorvs
commented
Dec 16, 2022
| @@ -33,6 +33,8 @@ dependencies { | |||
|
|
|||
| implementation Kotlin.stdlib.jdk7 | |||
| implementation "com.squareup.logcat:logcat:_" | |||
| // implementation "com.duckduckgo.mobile.android:ddg-android-netguard-release:1.0.0" | |||
| implementation "com.github.duckduckgo:netguard:jitpack-SNAPSHOT" | |||
There was a problem hiding this comment.
This is to be changed to version number once duckduckgo/netguard#12 is merged and we create the version tag
aitorvs
commented
Dec 16, 2022
Comment on lines
-52
to
-57
| externalNativeBuild { | ||
|
|
||
| cmake { | ||
| path "CMakeLists.txt" | ||
| } | ||
| } |
aitorvs
force-pushed
the
feature/aitor/atp/netguard_lib
branch
from
456c3cf to
fcb921e
Compare
aitorvs
force-pushed
the
feature/aitor/atp/netguard_lib
branch
from
fcb921e to
3981327
Compare
nshuba
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1203208709178851/f
Description
Remove netguard submodule and consume it as a library dependency
Steps to test this PR
vpn-network/vpn-network-impl/src/main/cppis deleted