New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libraries #2268

Merged

nalcalag merged 1 commit into develop from feature/noelia/update_libraries_sep

Sep 19, 2022

Contributor

nalcalag commented Sep 9, 2022 •

edited

Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1202931855800695/f

Description

⬆️ Update following libraries:

version.androidx.appcompat=1.5.1
version.org.jsoup..jsoup=1.15.3
version.org.threeten..threetenbp=1.6.1
version.com.facebook.flipper..flipper=0.163.0

Steps to test this PR

All unit tests should pass.
Run through the app and check that there isn't any unexpected behavior.

Smoke test:

Onboarding CTAs
Add bookmarks and favorites
Disable/enable privacy protection
Share feedback
Fireproof a site and clear all data
Opening multiple tabs (and closing tabs + undo)
Enable App Tracking Protection

No UI changes


          dependencies updates

c8326f2

joshliebe self-assigned this

joshliebe approved these changes

View reviewed changes

Contributor

joshliebe left a comment

Tested, LGTM ✅

nalcalag merged commit 0447ae0 into develop

nalcalag deleted the feature/noelia/update_libraries_sep branch

September 19, 2022 18:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet