Use relinker to load native libraries #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
aitorvs
force-pushed
the
feature/aitor/relinker
branch
2 times, most recently
from
3fa9947 to
c8e3925
Compare
aitorvs
force-pushed
the
feature/aitor/relinker
branch
from
c8e3925 to
cce0e23
Compare
marcosholgado
approved these changes
Aug 25, 2022
| @@ -57,6 +57,8 @@ version.com.android.installreferrer..installreferrer=2.2 | |||
|
|
|||
| version.com.frybits.harmony..harmony=1.1.11 | |||
|
|
|||
| version.com.getkeepsafe.relinker..relinker=1.4.5 | |||
There was a problem hiding this comment.
nit: Don't think we are using this version because of implementation "com.getkeepsafe.relinker:relinker:_" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1202242362471737/f
Description
Use
ReLinker(as also suggested by Google in here) to avoid issues when linking native libraryes. Like the ones we see with the bloom filter.ReLinker internaly uses
System.loadLibrary()but falls back to do their own thing when that fails. So it should not worsen the situation.Steps to test this PR
Test libary loading
HttpsBloomFilterFactoryImplFound https data at /data/user/0/com.duckduckgo.mobile.android.debug/files/HTTPS_BINARY_FILE, building filterandLoading took...logs appearError creating the bloom filterdoes not appear