Add ServiceWorkerLifecycleObserver to BrowserActivity lifecycle instead of Application #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of Application
joshliebe
reviewed
Aug 3, 2022
app/src/main/java/com/duckduckgo/app/browser/serviceworker/ServiceWorkerLifecycleObserver.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1202712032214375/f
Description
Another attempt to fix the crashes / anrs related to ServiceWorkerClient. Instead of setting the ServiceWorkerClient on application onStart() which might be too early in the process, we are delaying it to BrowserActivity's onCreate just before any webview is rendered.
Steps to test this PR
http://privacy-test-pages.glitch.me/privacy-protections/request-blocking/and make sure the service worker request is blocked (colour is not green)