Module tidy up for autofill #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlenDimla
approved these changes
Jul 1, 2022
CDRussell
added a commit
that referenced
this pull request
Jul 14, 2022
* Create autofill base branch * Initial implementation of Secure Storage with L1 encryption (#1924) Task/Issue URL: https://app.asana.com/0/0/1202210732792278/f Description This PR includes: API following API design Database structure for secure storage Initial implementation of SecureStorage API with L1 using SQLCipher This PR doesn't include: complete tests. I will add that on the next tasks. Steps to test this PR Not applicable UI changes None * Create autofill base branch * Create autofill base branch * Create autofill base branch * Address comments in #1924 (#1926) Task/Issue URL: N/A Description Addressing all comments mentioned in #1924 Steps to test this PR N/A UI changes N/A * Partial implementation of credential autofill (incomplete, non-pretty) (#1969) Task/Issue URL: https://app.asana.com/0/0/1202361561968346/f Partial, unpolished implementation of autofill. Most functionality is available. **Included** - saving credentials - autofilling credentials into sites - credentials management screen (accessible from settings) - view saved credentials - delete - edit credentials - copy username - copy password **Still to be done** - A nice UI 🙈 - Cody tidy-up - Device authentication * Implement device auth module (#1994) Task/Issue URL: https://app.asana.com/0/0/1202418883857446/f Description This PR introduces the DeviceAuthentication API which can be used to launch the device authentication flow using (Fingerprint, PIN, pattern or password) Steps to test this PR This currently is not used in any feature at the moment * Integrate device authentication to autofill (#1995) Task/Issue URL: https://app.asana.com/0/0/1202418883857448/f PR depends on: #1994 Description This PR integrates the device auth flow into the autofill flow. This doesn't include the full flow in management page since the page will likely change in implementation since it is still in the MVP stage. Will address this in https://app.asana.com/0/0/1202418883857449/f Steps to test this PR User has device auth enrolled on device Open a website with log in. Saves credentials without needing to do any authentication. Log out and attempt to login using saved credentials. Authentication using whatever is enrolled to the device (Fingerprint, faceid, pin, password or pattern) should be required everytime when trying to autofill a login. Open the management screen in settings. Authentication should be required every time. User has no device auth enrolled on device Open a website with log in. Save credential should not be shown. If a credential was previously saved, no prompt to autofill should be shown. Management link in settings should be disabled. * Implement L2 encryption on secure storage (#1980) Task/Issue URL: https://app.asana.com/0/0/1202210732792279/f Description This PR adds the L2 encryption for passwords in the secure storage. What's not yet included: expiring sessions / passwords user authentication on secure storage Steps to test this PR Use autofill [Make sure to clear storage before you install this changes) Open a website with login Login and save password in autofill Open the autofill manage screen Check if password shown is correct * Fix failures on tests for PRs against autofill_base (#2002) Task/Issue URL: https://app.asana.com/0/0/1202463484351795/f Description This PR includes: Pointing to a different commit for autofill instead of 4.6.0 to make autofill_base changes to work Add baseline files for new modules Delete submodules/autofill - since this is causing issues. * Remove auth related code on secure storage (#1998) Task/Issue URL: https://app.asana.com/0/0/1202434443764031/f Description Removal of user authentication from the secure storage API v1 Steps to test this PR Not applicable * Add tests to secure-storage (#2000) Task/Issue URL: https://app.asana.com/0/0/1202253978523860/f Stack on: #1980 Description This PR includes a few refactoring and addition for tests for secure storage classes. Steps to test this PR Sanity test autofill * Align autofill device authentication to design and copy (#2013) * Update text for auth flow * Add strings for locked and disable modes * Remove logic for disabling settings link for autofill when no auth is available * Add locked mode UI * Add disabled mode UI * Integrate locked and disabled states in management screen * Avoid blank screen where auth result is not successful upon first launch Co-authored-by: Craig Russell <CDRussell@users.noreply.github.com> * Inline autofill with new JS communication mechanism (#1973) Task/Issue URL: https://app.asana.com/0/0/1202370114120269/f ### Description Switching away from using `window.postMessage` to injecting in configuration and available input types directly. ### Not included (to be done in future PRs) - Handling the "update saved login" flow" - Pretty UI - Improvements to credential management screen - More tests ### Steps to test this PR FOR FIRST TESTS, ENSURE DEVICE AUTH IS **ENABLED** #### Test no Autofill where you have not saved credentials - [x] Visit site with a login (e.g., https://trello.com/login) - [x] Click on email field; verify no autofill prompts #### Test Autofill offers to save when logging in - [x] Visit site with a login (e.g., https://trello.com/login) (tip: don't have to use valid login details on trello to save dialog) - [x] Enter login details and press "log in" button - [x] Verify dialog shown asking if you want to save login details - [x] Choose to save, then logout/refresh the page - [x] Click on email field; verify that you do see the autofill prompt #### Test Autofill offers to save when logging in - [x] Visit trello login page https://trello.com/login - [x] Enter login details and press "log in" button - [x] Verify dialog shown asking if you want to save login details - [x] Choose not to save, refresh and verify credentials not offered to autofill - [x] Repeat the above steps, but this time choose to save, then logout/refresh the page - [x] Click on email field; verify that you do see the autofill prompt #### Test login credentials autofilled when chosen - [x] Carrying on from last test where you'll have saved login credentials for trello... - [x] Enter login details and press "log in" button - [x] Verify you see dialog with saved login shown - [x] Choose to use the saved login - [x] Verify you see the auth prompt. - [x] Let it fail - [x] Verify autofill doesn't happen - [x] Repeat the above (you'll have to refresh the page), this time let auth succeed - [x] Verify autofill does happen FOR THESE TESTS, ENSURE DEVICE AUTH IS **DISABLED** #### Test login credentials autofilled when chosen - [x] Repeat tests above, verifying that autofill prompts are never shown Co-authored-by: Karl Dimla <klmbdimla@gmail.com> * Disable save prompt when autofill toggle disabled (#2018) * Restrict autofill to internal test users (#2020) Task/Issue URL: https://app.asana.com/0/0/1202494823153095/f ### Description This PR includes - Introducing a mechanism to allow users to be internal test users - Enabled autofill only for internal test users ### Steps to test this PR _User is NOT an internal tester_ - [x] Open a website login - [x] Enter credentials - [x] Check that Autofill save dialog doesn't show - [x] Open Settings - [x] Check that Autofill management doesn't show _User is opens internal tester success url_ - [x] Open a https://use-login.duckduckgo.com/patestsucceeded - [x] Error page should load - [x] Check that Autofill management doesn't show in Settings - [x] Check that Autofill save dialog doesn't show when attempting to login in any website _User is signs up to be internal test user_ - [x] Open a https://use-login.duckduckgo.com - [x] Complete setup - [x] Check that Autofill management shows in Settings - [x] Check that Autofill is enabled by default - [x] Check that Autofill save dialog shows when attempting to login in any website - [x] Check that Autofill dialog shows when attempting to login in any website with saved credentials _User is signs up to be internal test user but autofill is disbled_ - [x] Open a https://use-login.duckduckgo.com - [x] Complete setup - [x] Check that Autofill management shows in Settings - [x] Disabled autofill - [x] Check that Autofill save dialog doesn't show when attempting to login in any website - [x] Check that Autofil dialog doesn't show when attempting to loginin any website with saved credentials * Add flag to easily enable debug mode for autofill (#2025) Task/Issue URL: https://app.asana.com/0/414730916066338/1202532114531456/f ### Description Adds a boolean to enable autofill debug mode. This is will stay `false` for default so we always test against the production impl and only toggled locally to `true` for debugging autofill integration issues. ### Steps to test this PR Set the flag to true and add a logcat filter for `console`; verify you see lots more console output Set it back to false and verify everything working as expected * Restore guard that was removed as a temporary fix (#2021) Task/Issue URL: https://app.asana.com/0/0/1202525190970047/f ### Description Remove a temporary fix now that the real fix is coming through a JS update. * Module tidy up for autofill (#2030) Task/Issue URL: https://app.asana.com/0/0/1202539310746053/f ### Description Minor tidy up around where to place files in modules ### Steps to test this PR That everything still compiles and checks pass is enough * Fix known issues for Autofill (#2027) Task/Issue URL: https://app.asana.com/0/0/1202518798495133/f https://app.asana.com/0/0/1202518798495138/f Description This PR includes: Add handling for Xiaomi devices when launching settings page Synchronizing functions accessing the Cipher and separating cipher for encryption and decryption Steps to test this PR Smoke test autofill * Move EmailManager to browser-api module (#2032) Task/Issue URL: https://app.asana.com/0/0/1202540505198731/f ### Description Move `EmailManager` to `browser-api` module (as per previous PR feedback) ### Steps to test this PR - [ ] Check that email autofill still works as expected * Make internal builds automatically internal test users (#2034) Task/Issue URL: https://app.asana.com/0/0/1202494823153095/f Description This PR includes automatically making the user an internal test user when using an internal build. Steps to test this PR Internal build Use internal build Verify that autofill is still available Internal build, failed verifications Use internal build Open use-login.duckduckgo.com/patestsucceeded (without going through verifcation) this should show the error page. Verify that autofill is still available Other builds Use any build that is not internal Autofill should NOT be available. Go through verification in use-login.duckduckgo.com Verify that autofill is still available * Autofill: loose end tidy up (#2037) * Tidy strings resources * Remove onConsoleMessage webview callback * Tidy lint baseline * Remove unused proguard files * Tidy library dependencies * Tidy autofill layouts and internationlize strings * Tidy module test declarations * Standardise capitalisation on string resources * Tidy build.gradle files * Tidy build.gradle * Address design review changes for Autofill auth (#2036) Task/Issue URL: https://app.asana.com/0/0/1202517616610078/f Description This PR includes the following: Fix dark mode for Autofill management disabled mode Add toolbar on autofill management (basic toolbar) Fix usage of Autofill management locked mode Improve disabled mode text linebreak Changes to the Autofill management locked mode Addition of FLAG_SECURE in AutofillManagementActivity Updates to the copy for Autofill management disabled mode * Remove modules directory * tidy: inline variable * tidy: build.gradle file, remove unnecessary config * tidy: remove exported property from autofill activity * Update app/build.gradle Co-authored-by: Karl Dimla <klmbdimla@gmail.com> * tidy: autofill build.gradle files, removed unneccessary config * tidy: autofill build.gradle files, removed unneccessary config * tidy: autofill build.gradle files, removed unneccessary config * tidy: delete unused layout * tidy: di usage around javascript interface * tidy: remove unused strings * Document public autofill-api classes * Tolerate fingerprint-read failures before giving up on auth (#2064) * Add exported:false in autofill-impl manifest * tidy: Change gradle dependency from api to implentation * tidy: change DI scope for viewmodel * tidy: change DI scope for viewmodel Co-authored-by: Karl Dimla <klmbdimla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1202539310746053/f
Description
Minor tidy up around where to place files in modules
Steps to test this PR
That everything still compiles and checks pass is enough