Multi-process shared prefs #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
aitorvs
commented
May 8, 2022
aitorvs
force-pushed
the
feature/aitor/atp/harmony
branch
2 times, most recently
from
ec81256 to
e93939e
Compare
aitorvs
commented
May 9, 2022
|
|
||
| import android.content.SharedPreferences | ||
|
|
||
| class InMemorySharedPreferences : SharedPreferences, SharedPreferences.Editor { |
There was a problem hiding this comment.
Added this class to easily fake shared preferences. The usage of this is limited right now. We can create a subsequent task to increase test coverage when possible
aitorvs
commented
May 9, 2022
vpn-store/src/main/java/com/duckduckgo/mobile/android/vpn/store/VpnDatabase.kt
Show resolved
Hide resolved
aitorvs
commented
May 9, 2022
vpn/src/main/java/com/duckduckgo/mobile/android/vpn/pixels/DeviceShieldPixels.kt
Show resolved
Hide resolved
aitorvs
commented
May 9, 2022
Comment on lines
+27
to
+29
| interface VpnSharedPreferencesProvider { | ||
| fun getSharedPreferences(name: String, multiprocess: Boolean = false): SharedPreferences | ||
| } |
There was a problem hiding this comment.
This is only in the :vpn module for now. If we like this pattern we can move it to eg. :common module and use it across the app (which I think we should). But it's kind of out of scope of this PR I think
There was a problem hiding this comment.
I personally like the idea.
aitorvs
force-pushed
the
feature/aitor/atp/harmony
branch
from
e93939e to
cfcfbb2
Compare
aitorvs
commented
May 9, 2022
vpn/src/main/java/com/duckduckgo/mobile/android/vpn/ui/onboarding/VpnStore.kt
Show resolved
Hide resolved
malmstein
approved these changes
May 10, 2022
Comment on lines
+27
to
+29
| interface VpnSharedPreferencesProvider { | ||
| fun getSharedPreferences(name: String, multiprocess: Boolean = false): SharedPreferences | ||
| } |
There was a problem hiding this comment.
I personally like the idea.
| return runBlocking(dispatcherProvider.io()) { | ||
| vpnDatabasePreferences.getPreference(KEY_ALWAYS_ON_MODE_ENABLED)?.value ?: false | ||
| } | ||
| return preferences.getBoolean(KEY_ALWAYS_ON_MODE_ENABLED, false) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1202242242171822/f
Description
Multi-process shared prefs
Steps to test this PR
Smoke tests for browser and AppTP
Repeat always on tests