Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Mockito 4, sort out test config problems #1640

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Upgrade to Mockito 4, sort out test config problems #1640

merged 1 commit into from
Dec 24, 2021

Conversation

CDRussell
Copy link
Member

Task/Issue URL: https://app.asana.com/0/0/1201589003047297/f

Description

Tidies up Mockito test dependencies, and upgrades to latest Mockito 4.2.0

Steps to test this PR

ℹ️ make sure you perform a gradle sync before testing in the IDE

  1. Run ./gradlew checks and verify everything passing
  2. Open some test classes in IDE and check IDE not reporting any errors. e.g., WebViewLongPressHandlerTest, which shouldn't show an error on openMocks usage.

anikiki
anikiki approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@anikiki anikiki merged commit 9b60293 into develop Dec 24, 2021
@anikiki anikiki deleted the feature/craig/fix_test_configuration branch December 24, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikiki anikiki anikiki approved these changes

Assignees

@anikiki anikiki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CDRussell @anikiki