Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Kotlin 1.6.10 #1634

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Upgrade to Kotlin 1.6.10 #1634

merged 1 commit into from
Dec 20, 2021
+13 −7

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Dec 20, 2021 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1201539840759397/f

Description

Upgrades the kotlin version. This creates some compilation errors, and an incompatibility with Anvil so that is updated too.

Library Before After Notes
Kotlin 1.5.10 1.6.10
Anvil 2.3.3 2.3.10-1-6-0 See Anvil releases to explain prefix

Steps to test this PR

  • Ensure ./gradlew checks passes (ignoring known flaky tests if they present)
  • Smoke test the app to ensure no regressions have slipped in

@CDRussell CDRussell marked this pull request as ready for review December 20, 2021 15:32
anikiki
anikiki approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@anikiki anikiki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the upgrade! 🎉 Didn't find any issues during smoke testing and ./gradlew checks worked as expected.

@CDRussell CDRussell merged commit 079bec9 into develop Dec 20, 2021
@CDRussell CDRussell deleted the feature/craig/upgrade_kotlin_1.6.10 branch December 20, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitorvs aitorvs aitorvs left review comments

@anikiki anikiki anikiki approved these changes

Assignees

@anikiki anikiki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CDRussell @aitorvs @anikiki