Allow AppScope -> ActivityScope -> FragmentScope dagger scope nesting #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open. |
aitorvs
force-pushed
the
feature/aitor/singlein
branch
from
2120ac1 to
541e259
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
4 times, most recently
from
bfe4c5f to
eede887
Compare
aitorvs
force-pushed
the
feature/aitor/singlein
branch
from
d1288ae to
2418f88
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
eede887 to
da1639e
Compare
aitorvs
force-pushed
the
feature/aitor/singlein
branch
from
2418f88 to
4fac7d1
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
da1639e to
d29dfb4
Compare
aitorvs
force-pushed
the
feature/aitor/singlein
branch
from
4fac7d1 to
85bea57
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
d29dfb4 to
ca9cec2
Compare
aitorvs
force-pushed
the
feature/aitor/singlein
branch
from
85bea57 to
de9c77e
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
ca9cec2 to
76fd750
Compare
aitorvs
force-pushed
the
feature/aitor/singlein
branch
from
de9c77e to
bb87d74
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
76fd750 to
b484a1f
Compare
aitorvs
force-pushed
the
feature/aitor/singlein
branch
from
bb87d74 to
2a4520a
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
b484a1f to
df8be0f
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
df8be0f to
0ff881c
Compare
marcosholgado
approved these changes
Dec 13, 2021
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
0ff881c to
91c6ea4
Compare
aitorvs
force-pushed
the
feature/aitor/dagger_nesting
branch
from
91c6ea4 to
b177b55
Compare
CDRussell
pushed a commit
that referenced
this pull request
Dec 15, 2021
…#1604) Task/Issue URL: https://app.asana.com/0/414730916066338/1201432423603230/f ### Description In PR #1597 we're harmonising the way we name dagger components and how we contribute dependencies to them. As a recap: * Use @SingletonIn(AppScope::class) for app scope * Use @SingletonIn(ActivityScope::class) for activity scope * Use @SingletonIn(FragmentScope::class) for fragment scope This a follow up PR to enable nesting those scopes: * AppScope -> ActivityScope -> FragmentScope Nesting means: * child scopes can get access to dependencies in their parent scopes (but not the other way around), ie. * `FragmentScope` would get access to deps in Fragment, Activity and App scopes * `ActivityScope` would get access to deps in Activity and App scopes * `AppScope` would get access to deps in App scope The PR changes the fragments that were not in the `FragmentScope` to use that one instead. Functionality should not be affected at all ### Steps to test this PR Smoke tests for app and AppTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414730916066338/1201432423603230/f
Description
In PR #1597 we're harmonising the way we name dagger components and how we contribute dependencies to them. As a recap:
This a follow up PR to enable nesting those scopes:
Nesting means:
FragmentScopewould get access to deps in Fragment, Activity and App scopesActivityScopewould get access to deps in Activity and App scopesAppScopewould get access to deps in App scopeThe PR changes the fragments that were not in the
FragmentScopeto use that one instead. Functionality should not be affected at allSteps to test this PR
Smoke tests for app and AppTP