Implement pm.safeGetInstalledApplications to avoid binder crash when too many apps are installed (#7026)

Task/Issue URL:
https://app.asana.com/1/137249556945/project/1202552961248957/task/1211783744622977?focus=true

### Description
See attached task description

### Steps to test this PR
Smoke test AppTP and VPN
- Exclusion list
- App TP trackers (main feed and recent activity)
- Install new app

---------

Co-authored-by: Karl Dimla <klmbdimla@gmail.com>

Author: aitorvs

app-tracking-protection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/apps/TrackingProtectionAppsRepository.kt

@@ -21,6 +21,7 @@ import android.content.pm.ApplicationInfo
 import android.content.pm.PackageManager
 import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.common.utils.extensions.isDdgApp
+import com.duckduckgo.common.utils.extensions.safeGetInstalledApplications
 import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.mobile.android.vpn.apps.TrackingProtectionAppsRepository.ProtectionState
 import com.duckduckgo.mobile.android.vpn.apps.TrackingProtectionAppsRepository.ProtectionState.PROTECTED
@@ -113,15 +114,15 @@ class RealTrackingProtectionAppsRepository @Inject constructor(
 
     private fun refreshInstalledApps() {
         logcat { "Excluded Apps: refreshInstalledApps" }
-        installedApps = packageManager.getInstalledApplications(PackageManager.GET_META_DATA)
+        installedApps = packageManager.safeGetInstalledApplications(context)
             .asSequence()
             .filterNot { shouldNotBeShown(it) }
     }
 
     override suspend fun getExclusionAppsList(): List<String> = withContext(dispatcherProvider.io()) {
         val exclusionList = appTrackerRepository.getAppExclusionList()
         val manualExclusionList = appTrackerRepository.getManualAppExclusionList()
-        return@withContext packageManager.getInstalledApplications(PackageManager.GET_META_DATA)
+        return@withContext packageManager.safeGetInstalledApplications(context)
             .asSequence()
             .filter { isExcludedFromAppTP(it, exclusionList, manualExclusionList) }
             .sortedBy { it.name }

app-tracking-protection/vpn-impl/src/test/java/com/duckduckgo/mobile/android/vpn/apps/TrackingProtectionAppsRepositoryTest.kt

@@ -16,6 +16,7 @@
 
 package com.duckduckgo.mobile.android.vpn.apps
 
+import android.annotation.SuppressLint
 import android.content.pm.ApplicationInfo
 import android.content.pm.PackageManager
 import android.content.pm.PackageManager.NameNotFoundException
@@ -49,6 +50,7 @@ class TrackingProtectionAppsRepositoryTest {
     private lateinit var trackingProtectionAppsRepository: TrackingProtectionAppsRepository
 
     @Before
+    @SuppressLint("DenyListedApi")
     fun setup() {
         whenever(packageManager.getInstalledApplications(PackageManager.GET_META_DATA)).thenReturn(INSTALLED_APPS.asApplicationInfo())
         whenever(packageManager.getApplicationLabel(any())).thenReturn("App Name")

app-tracking-protection/vpn-internal/src/main/java/com/duckduckgo/vpn/internal/feature/VpnInternalSettingsActivity.kt

@@ -18,7 +18,6 @@ package com.duckduckgo.vpn.internal.feature
 
 import android.content.Intent
 import android.content.pm.ApplicationInfo
-import android.content.pm.PackageManager
 import android.os.Bundle
 import android.widget.CompoundButton
 import androidx.core.view.isVisible
@@ -35,6 +34,7 @@ import com.duckduckgo.common.ui.viewbinding.viewBinding
 import com.duckduckgo.common.utils.ConflatedJob
 import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.common.utils.extensions.isDdgApp
+import com.duckduckgo.common.utils.extensions.safeGetInstalledApplications
 import com.duckduckgo.di.scopes.ActivityScope
 import com.duckduckgo.mobile.android.app.tracking.AppTrackingProtection
 import com.duckduckgo.mobile.android.vpn.apps.isSystemApp
@@ -164,7 +164,7 @@ class VpnInternalSettingsActivity : DuckDuckGoActivity() {
     }
 
     private fun refreshInstalledApps() {
-        installedApps = packageManager.getInstalledApplications(PackageManager.GET_META_DATA)
+        installedApps = packageManager.safeGetInstalledApplications(this.applicationContext)
             .asSequence()
             .filterNot { shouldNotBeShown(it) }
     }

app-tracking-protection/vpn-internal/src/main/java/com/duckduckgo/vpn/internal/feature/rules/ExceptionRulesDebugActivity.kt

@@ -29,6 +29,7 @@ import com.duckduckgo.common.ui.DuckDuckGoActivity
 import com.duckduckgo.common.ui.viewbinding.viewBinding
 import com.duckduckgo.common.utils.ConflatedJob
 import com.duckduckgo.common.utils.DispatcherProvider
+import com.duckduckgo.common.utils.extensions.safeGetInstalledApplications
 import com.duckduckgo.di.scopes.ActivityScope
 import com.duckduckgo.mobile.android.vpn.stats.AppTrackerBlockingStatsRepository
 import com.duckduckgo.mobile.android.vpn.store.VpnDatabase
@@ -113,7 +114,7 @@ class ExceptionRulesDebugActivity : DuckDuckGoActivity(), RuleTrackerView.RuleTr
     }
 
     private fun getAppTrackers(): List<InstalledAppTrackers> {
-        return packageManager.getInstalledApplications(PackageManager.GET_META_DATA)
+        return packageManager.safeGetInstalledApplications(this.applicationContext)
             .asSequence()
             .map { InstalledApp(it.packageName, packageManager.getApplicationLabel(it).toString()) }
             .map {

app/src/main/java/com/duckduckgo/app/systemsearch/DeviceAppLookup.kt

@@ -16,6 +16,7 @@
 
 package com.duckduckgo.app.systemsearch
 
+import android.annotation.SuppressLint
 import android.content.Intent
 import android.content.pm.PackageManager
 import android.content.pm.PackageManager.GET_META_DATA
@@ -92,6 +93,7 @@ interface DeviceAppListProvider {
     suspend fun get(): List<DeviceApp>
 }
 
+@SuppressLint("DenyListedApi")
 class InstalledDeviceAppListProvider(
     private val packageManager: PackageManager,
     private val dispatcherProvider: DispatcherProvider,

common/common-utils/src/main/java/com/duckduckgo/common/utils/extensions/PackageManagerExtension.kt

@@ -16,6 +16,9 @@
 
 package com.duckduckgo.common.utils.extensions
 
+import android.annotation.SuppressLint
+import android.content.Context
+import android.content.pm.ApplicationInfo
 import android.content.pm.PackageManager
 import android.graphics.drawable.Drawable
 
@@ -24,3 +27,13 @@ fun PackageManager.safeGetApplicationIcon(packageName: String): Drawable? {
         getApplicationIcon(packageName)
     }.getOrNull()
 }
+
+@SuppressLint("DenyListedApi")
+fun PackageManager.safeGetInstalledApplications(context: Context): List<ApplicationInfo> {
+    return try {
+        this.getInstalledApplications(PackageManager.GET_META_DATA)
+    } catch (_: Throwable) {
+        // at least we know our app is installed :)
+        listOf(this.getApplicationInfo(context.packageName, PackageManager.GET_META_DATA))
+    }
+}

lint-rules/src/main/java/com/duckduckgo/lint/DenyListedApiDetector.kt

@@ -40,6 +40,11 @@ import java.util.EnumSet
  */
 internal class DenyListedApiDetector : Detector(), SourceCodeScanner, XmlScanner {
     private val config = DenyListConfig(
+        DenyListedEntry(
+            className = "android.content.pm.PackageManager",
+            functionName = "getInstalledApplications",
+            errorMessage = "Use PackageManager.safeGetInstalledApplications() instead"
+        ),
         DenyListedEntry(
             className = "kotlinx.coroutines.flow.FlowKt__ReduceKt",
             functionName = "first",

network-protection/network-protection-impl/src/main/java/com/duckduckgo/networkprotection/impl/autoexclude/AutoExcludeAppsRepository.kt

@@ -16,9 +16,11 @@
 
 package com.duckduckgo.networkprotection.impl.autoexclude
 
+import android.content.Context
 import android.content.pm.PackageManager
 import com.duckduckgo.app.di.AppCoroutineScope
 import com.duckduckgo.common.utils.DispatcherProvider
+import com.duckduckgo.common.utils.extensions.safeGetInstalledApplications
 import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.networkprotection.store.db.AutoExcludeDao
 import com.duckduckgo.networkprotection.store.db.FlaggedIncompatibleApp
@@ -93,6 +95,7 @@ class RealAutoExcludeAppsRepository @Inject constructor(
     @AppCoroutineScope private val appCoroutineScope: CoroutineScope,
     private val autoExcludeDao: AutoExcludeDao,
     private val packageManager: PackageManager,
+    private val context: Context,
 ) : AutoExcludeAppsRepository {
 
     private val autoExcludeList: Deferred<List<VpnIncompatibleApp>> = appCoroutineScope.async(start = CoroutineStart.LAZY) {
@@ -133,7 +136,7 @@ class RealAutoExcludeAppsRepository @Inject constructor(
 
     override suspend fun getInstalledIncompatibleApps(): List<VpnIncompatibleApp> {
         return withContext(dispatcherProvider.io()) {
-            val installedApps = packageManager.getInstalledApplications(PackageManager.GET_META_DATA).map { it.packageName }
+            val installedApps = packageManager.safeGetInstalledApplications(context).map { it.packageName }
 
             autoExcludeList.await().filter {
                 installedApps.contains(it.packageName)

network-protection/network-protection-impl/src/main/java/com/duckduckgo/networkprotection/impl/exclusion/NetpExclusionListRepository.kt

@@ -16,9 +16,11 @@
 
 package com.duckduckgo.networkprotection.impl.exclusion
 
+import android.content.Context
 import android.content.pm.ApplicationInfo
 import android.content.pm.PackageManager
 import com.duckduckgo.common.utils.DispatcherProvider
+import com.duckduckgo.common.utils.extensions.safeGetInstalledApplications
 import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.networkprotection.impl.autoexclude.AutoExcludeAppsRepository
 import com.duckduckgo.networkprotection.impl.settings.NetPSettingsLocalConfig
@@ -42,6 +44,7 @@ class RealNetPExclusionListRepository @Inject constructor(
     private val netPSettingsLocalConfig: NetPSettingsLocalConfig,
     private val dispatcherProvider: DispatcherProvider,
     private val packageManager: PackageManager,
+    private val context: Context,
 ) : NetPExclusionListRepository {
     override suspend fun getExcludedAppPackages(): List<String> {
         return withContext(dispatcherProvider.io()) {
@@ -52,7 +55,7 @@ class RealNetPExclusionListRepository @Inject constructor(
                 emptyList()
             }
 
-            packageManager.getInstalledApplications(PackageManager.GET_META_DATA).asSequence()
+            packageManager.safeGetInstalledApplications(context).asSequence()
                 .filter { isExcludedFromVpn(it, manuallyExcludedApps, autoExcludeApps) }
                 .sortedBy { it.name }
                 .map { it.packageName }

network-protection/network-protection-impl/src/main/java/com/duckduckgo/networkprotection/impl/exclusion/systemapps/SystemAppsExclusionRepository.kt

@@ -16,11 +16,13 @@
 
 package com.duckduckgo.networkprotection.impl.exclusion.systemapps
 
+import android.content.Context
 import android.content.SharedPreferences
 import android.content.pm.ApplicationInfo
 import android.content.pm.PackageManager
 import androidx.core.content.edit
 import com.duckduckgo.common.utils.DispatcherProvider
+import com.duckduckgo.common.utils.extensions.safeGetInstalledApplications
 import com.duckduckgo.data.store.api.SharedPreferencesProvider
 import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.feature.toggles.api.Toggle.State
@@ -68,6 +70,7 @@ class RealSystemAppsExclusionRepository @Inject constructor(
     private val packageManager: PackageManager,
     private val systemAppOverridesProvider: SystemAppOverridesProvider,
     private val dispatcherProvider: DispatcherProvider,
+    private val context: Context,
 ) : SystemAppsExclusionRepository {
     private val preferences: SharedPreferences by lazy {
         sharedPreferencesProvider.getSharedPreferences(
@@ -200,7 +203,7 @@ class RealSystemAppsExclusionRepository @Inject constructor(
     }
 
     private fun getOtherSystemApps(): Set<String> {
-        return packageManager.getInstalledApplications(PackageManager.GET_META_DATA)
+        return packageManager.safeGetInstalledApplications(context)
             .asSequence()
             .filter { it.isSystemApp() && !it.isSystemAppOveridden() && !it.isCategorized() }
             .map { it.packageName }