Fix SQLiteConstraintException spike crashes (#4558)

Task/Issue URL: https://app.asana.com/0/488551667048375/1207351226753468/f ### Description Gracefully stop the VPN in case of `code 1555 SQLITE_CONSTRAINT_PRIMARYKEY` db error ### Steps to test this PR NA, just code review
duckduckgo · May 20, 2024 · f078095 · f078095
1 parent 013041b
commit f078095
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/...impl/src/main/java/com/duckduckgo/mobile/android/vpn/service/TrackerBlockingVpnService.kt b/...impl/src/main/java/com/duckduckgo/mobile/android/vpn/service/TrackerBlockingVpnService.kt
@@ -298,7 +298,11 @@ class TrackerBlockingVpnService : VpnService(), CoroutineScope by MainScope(), V
         deviceShieldPixels.reportVpnStartAttempt()
         dnsChangeCallback.unregister()
 
-        vpnServiceStateStatsDao.insert(createVpnState(state = ENABLING))
+        runCatching {
+            vpnServiceStateStatsDao.insert(createVpnState(state = ENABLING))
+        }.onFailure {
+            stopVpn(VpnStopReason.ERROR, false)
+        }
 
         logcat { "VPN log: Starting VPN" }
         val restarting = activeTun != null
@@ -382,7 +386,12 @@ class TrackerBlockingVpnService : VpnService(), CoroutineScope by MainScope(), V
         }
 
         // lastly set the VPN state to enabled
-        vpnServiceStateStatsDao.insert(createVpnState(state = ENABLED))
+        runCatching {
+            vpnServiceStateStatsDao.insert(createVpnState(state = ENABLED))
+        }.onFailure {
+            // onVpnStarted or onVpnReconfigured already called, ie. hasVpnAlreadyStarted = true
+            stopVpn(VpnStopReason.ERROR, true)
+        }
 
         // This is something temporary while we confirm whether we're able to fix the moto g issues with appTP
         // see https://app.asana.com/0/488551667048375/1203410036713941/f for more info
@@ -597,7 +606,9 @@ class TrackerBlockingVpnService : VpnService(), CoroutineScope by MainScope(), V
         }
 
         // Set the state to DISABLED here, then call the on stop/failure callbacks
-        vpnServiceStateStatsDao.insert(createVpnState(state = VpnServiceState.DISABLED, stopReason = reason))
+        runCatching {
+            vpnServiceStateStatsDao.insert(createVpnState(state = VpnServiceState.DISABLED, stopReason = reason))
+        }
 
         vpnStateServiceReference?.let {
             runCatching { unbindService(vpnStateServiceConnection).also { vpnStateServiceReference = null } }