Skip to content

Commit

Permalink
Record malware blocks (#5389)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/1142021229838617/1208368538104397/f

### Description
This PR bumps the our netguard (vpn) library to 1.7.0
Also adds the `recordMalwareBlock` callback, called from native when malware is blocked.

### Steps to test this PR

_Test_
- [x] Install from this branch and go through onboarding
- [x] Enabled VPN
- [x] filter logcat by "package:mine tag:GoBackend Malware blocked"
- [x] open tab and go to `vpn-malware.goduckgo.com`
- [x] verify "Malware blocked in vpn-malware.goduckgo.com" shows
- [x] Smoke test browser and VPN
  • Loading branch information
aitorvs authored Dec 13, 2024
1 parent f32c3ba commit 93d4adb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,12 @@ class GoBackend @Inject constructor(
return shouldAllowDomain(sni, uid)
}

// Called from native code
@Suppress("unused")
fun recordMalwareBlock(domain: String) {
logcat { "Malware blocked in $domain" }
}

private fun shouldAllowDomain(
name: String,
uid: Int,
Expand Down
2 changes: 1 addition & 1 deletion versions.properties
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ version.com.airbnb.android..lottie=5.2.0

version.com.android.installreferrer..installreferrer=2.2

version.com.duckduckgo.netguard..netguard-android=1.6.12
version.com.duckduckgo.netguard..netguard-android=1.7.0

version.com.duckduckgo.synccrypto..sync-crypto-android=0.3.0

Expand Down

0 comments on commit 93d4adb

Please sign in to comment.