Skip to content

Commit

Permalink
AppTP: Allow text on any breakage category (#2595)
Browse files Browse the repository at this point in the history
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
    3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->

Task/Issue URL:
https://app.asana.com/0/1202279501986195/1203481901002309/f

### Description
By adding categories, we gained more useful signal on breakage even when
people don't submit descriptions, but by limiting open text to only the
"Something Else" category, we also decreased reports that included any
text (down from about 64% before the change to just under 19% overall
since). Allowing users to add text for any category would be a quick win
to broaden signal a bit.

### Steps to test this PR

- Go to AppTP status page (or silent notification)
- Tap `Help us improve` -> `Submit a report` (or `Having problems with
an app`)
- Select an app
- Notice that you still must select a category, but all categories (not
just "Something else") will now allow text input

### UI changes
| Before  | After |
| ------ | ----- |

![oldReportScreen](https://user-images.githubusercontent.com/20972610/205370899-466309b9-91a9-4b5f-94eb-2c2b60b6780e.jpeg)|![newReportScreen](https://user-images.githubusercontent.com/20972610/205370923-30846529-e38c-4d13-9d46-c5e56efbdc65.jpeg)|

Co-authored-by: laghee <kmanning567@gmail.com>
  • Loading branch information
laghee and laghee authored Dec 8, 2022
1 parent 4f6b766 commit 405764f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import android.content.Context
import android.content.Intent
import android.os.Bundle
import android.util.Base64
import android.view.View
import androidx.appcompat.app.AlertDialog
import androidx.core.text.HtmlCompat
import androidx.lifecycle.Lifecycle.State.STARTED
Expand Down Expand Up @@ -151,7 +150,6 @@ class ReportBreakageCategorySingleChoiceActivity : DuckDuckGoActivity() {
val category =
viewState.categorySelected?.let { getString(viewState.categorySelected.category) }.orEmpty()
binding.categoriesSelection.setText(category)
binding.otherCategoryDescription.visibility = if (viewState.indexSelected == 8) View.VISIBLE else View.GONE
binding.ctaNextFormSubmit.isEnabled = viewState.submitAllowed
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical"
android:visibility="gone">
android:visibility="visible">

<TextView
android:id="@+id/appBreakageFormHeading"
Expand Down

0 comments on commit 405764f

Please sign in to comment.