Add Valgrind testing infrastructure for memory bug detection #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add script, Makefile target, and test case for memory bug detection. Usage: make valgrind-check PG_SRC=/path/to/postgres
|
@JelteF Can you help in reviewing this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Added Valgrind testing infrastructure to detect memory bugs. The changes include :
How I Tested
Script argument validation, error handling, formatting compliance, and regression test execution (56/57 tests pass, 1 pre-existing failure) using
make valgrind-check,./scripts/valgrind_pgduckdb.sh, andmake check-regression-duckdb. Identified potential memory leak insrc/pgduckdb_detoast.cpplines 130-140 where exception could preventduckdb_free(result)from executing.Fixes #218